Repository navigation
feat(import): feature-gate importers so legacy cron imports without the flows engine - #135
Merged
Merged
Conversation
…ows-import/src/lib.rs Auto-committed-on: dragonfly
The CI workflow now runs clippy and tests for tinyflows-import with only the schedule feature enabled, matching the existing coverage for the drivers crate. This ensures legacy cron jobs can still be imported without the flows engine. Auto-committed-on: dragonfly
The sorted_by test helper is now only compiled when the catalog feature is enabled, since it is used solely by catalog-related tests and would otherwise trigger dead code warnings in other configurations. Auto-committed-on: dragonfly
2 of 5 tasks
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the primary change: feature-gating importers so legacy cron imports can run without the flows engine. |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (2 skipped: 2 … |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the schedule gate,
With cron jobs queued and engine-free,
The features sort into their place,
While Clippy hops through happily,
And tests run clean as springtime tea.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Tiny Sweeper reviewTiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. How this fits togetherflowchart LR
n0["tree_digest"]:::impacted
n1["read"]:::impacted
n2["expected"]:::impacted
n3["Value"]:::impacted
n4["insert"]:::impacted
n5["digest"]:::impacted
n0 -->|calls| n1
n0 -->|tests| n1
n0 -->|calls| n4
n0 -->|tests| n4
n0 -->|calls| n5
n0 -->|tests| n5
n2 -->|calls| n1
n2 -->|tests| n1
n2 -->|uses| n3
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0005 · 275,189 in / 6,060 out · 37,120 cached (13%) · ladder/vectors-oai3, deepseek-v4.1-flash · 147 embedded
critique: $0.0002 · 114,089 in / 2,089 out · 15,488 cached (14%) · deepseek-v4.1-flash
security: $0.0001 · 74,942 in / 921 out · 9,856 cached (13%) · deepseek-v4.1-flash
tests: $0.0001 · 58,228 in / 958 out · 6,272 cached (11%) · deepseek-v4.1-flash
description: $0.0001 · 24,814 in / 859 out · 5,504 cached (22%) · deepseek-v4.1-flash
tinysweeper
Bot
added
the
priority: p3
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of tinyhumansai/openhuman#7662, tinyhumansai/openhuman#7522
What
tinyflows-importgains features (engine,store,catalog,schedule; all default-on) so a host without the flows engine can build withdefault-features = false, features = ["schedule"]and still import legacyjobs.dbcron jobs and runs (import_cron).tinyflows-driversis taken with default features off. CI now lints and tests the schedule-only importer build. The existing cron importer tests run in that configuration.Deferred (recorded on #7662)
tinyflows-driversinto the publishedtinyflowscrate: kept split by decision, still blocked becausetinystoragedrivers-coreis not on crates.io and a published crate cannot carry a git dependency.[patch]: needs the tinyflows tsd source to match tinyagents', an OpenHuman-side change.flowscallimport_cronwithschedule-only features, and supply the key list toimport_file_state(the legacy store hashes keys, so only the host knows them).Summary by CodeRabbit