Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Member
Author
|
@coderabbitai review |
|
…-7419-8-secret-cas
…-7419-80-session-backend
fix(config): keep composite blob option before URL fragments
…-7419-8-secret-cas
…l/tinystoragedrivers into epic-7419-80-session-backend
feat(sqlite): open existing storage read-only
…-7419-8-secret-cas
Member
Author
|
Closing: superseded by tinyhumansai/openhuman#8131, which restructures tinystoragedrivers into types + API + per-primitive crates with engines as features. Any capability still needed here gets re-implemented on that layout (secrets CAS in senamakel#30, blob listing in #27, sqlite open modes in #26). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecretStore currently has no atomic precondition, so callers that store credentials as whole profiles can overwrite a concurrent update. This adds paired versioned reads and atomic
set_ifwrites to native stores and the confidential Secrets bus contract.Document stores compare the opaque token and use the native document revision precondition for the write. Encrypted files compute versions from the file identity, secret name, and exact ciphertext snapshot while holding the existing cross-process lock; unrelated file updates conservatively conflict, without changing the file format. Memory stores use per-secret generations and store identity. Keyring reports typed
Unsupported(ConditionalSecretWrites)because it has no atomic CAS primitive.set_ifreturns the revision for its own committed write.The conformance suite covers stale and absent conditions, same-value rewrites, delete/recreate ABA, concurrent writers, and returned-token identity. Additional tests cover independent file handles and processes, storage-domain binding, the real bus client race, and keyring unsupported behavior. The bus contract is version 5; Secrets remains confidential.
Validation so far:
cargo fmt --allandgit diff --checkpass. Local Cargo checks/tests have not run because the shared local build slot is reserved for another leaf; hosted checks are pending. Keep this draft until required local and hosted gates are green.Refs senamakel#8
Part of tinyhumansai/openhuman#7419