Repository navigation
Remove unsafe TLC CurrentState JMX polling - #1507
Merged
Merged
Conversation
lemmy
requested changes
Nov 3, 2026
lemmy
left a comment
Member
There was a problem hiding this comment.
Please delete StateMonitor.java entirely. If it doesn't print states, it serves no purpose, as TLC already prints the standard statistics by default. There is also no need for a test case.
lemmy
approved these changes
Nov 3, 2026
Member
|
Please address the DCO CI check above. |
…ress in StateMonitor Updated StateMonitor to print additional statistics including states generated, queue size, and progress.[Bug][TLC] Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
[Bug][TLC] Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
[Bug][TLC] Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
[Bug][TLC] Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
[Bug][TLC] Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
wozhenbang2004
force-pushed
the
fix/tlc-jmx-current-state
branch
from
November 3, 2026 17:15
a786dac to
f3e3053
Compare
Member
|
Thanks @wozhenbang2004! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1506.
Remove the
CurrentStateJMX attribute from the TLC statistics interface and both wrappers. Reading it could enter the state queue’s worker wait logic. Delete theStateMonitorcommand. TLC already reports progress statistics.Validation