Skip to content

Remove unsafe TLC CurrentState JMX polling - #1507

Merged
lemmy merged 7 commits into
tlaplus:masterfrom
wozhenbang2004:fix/tlc-jmx-current-state
Nov 3, 2026
Merged

lemmy merged 7 commits into
tlaplus:masterfrom
wozhenbang2004:fix/tlc-jmx-current-state

Conversation

@wozhenbang2004

@wozhenbang2004 wozhenbang2004 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1506.

Remove the CurrentState JMX attribute from the TLC statistics interface and both wrappers. Reading it could enter the state queue’s worker wait logic. Delete the StateMonitor command. TLC already reports progress statistics.

Validation

  • Compiled TLC and its test sources.
  • Passed all 12 existing checkpoint tests.

@lemmy lemmy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete StateMonitor.java entirely. If it doesn't print states, it serves no purpose, as TLC already prints the standard statistics by default. There is also no need for a test case.

@lemmy

lemmy commented Nov 3, 2026

Copy link
Copy Markdown
Member

Please address the DCO CI check above.

@lemmy lemmy added bug error, glitch, fault, flaw, ... soundness \/ completeness Critical TLC bugs causing missed safety or liveness violations (soundness/completeness). labels Nov 3, 2026
…ress in StateMonitor

Updated StateMonitor to print additional statistics including states generated, queue size, and progress.[Bug][TLC]

Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
[Bug][TLC]

Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
[Bug][TLC]

Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
[Bug][TLC]

Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
[Bug][TLC]

Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
Signed-off-by: Kayokoi <113896798+wozhenbang2004@users.noreply.github.com>
@wozhenbang2004
wozhenbang2004 force-pushed the fix/tlc-jmx-current-state branch from a786dac to f3e3053 Compare November 3, 2026 17:15
@lemmy
lemmy merged commit 309e489 into tlaplus:master Nov 3, 2026
8 checks passed
@lemmy

lemmy commented Nov 3, 2026

Copy link
Copy Markdown
Member

Thanks @wozhenbang2004!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug error, glitch, fault, flaw, ... soundness \/ completeness Critical TLC bugs causing missed safety or liveness violations (soundness/completeness).

Development

Successfully merging this pull request may close these issues.

JMX state polling can make TLC report false success

2 participants