Skip to content

openclaw-tps-mail: widen obligation-lifecycle tests to the paths #406 covers by reasoning #408

Open

Description

@tps-flint

Follow-up from the #406 review (one mail routing rule; obligation lifecycle). The outcomes are correct after #406; these tests widen coverage so a regression on each path goes red:

  1. A delivery call that SENDS and then throws: the obligation resolves acked from the evidence (or unconfirmed), never failed.
  2. Attributable quarantine first discovered at the deadline (not in-turn): failed with receipt-malformed, one nack mail.
  3. An injected failure of the delivering write: nothing is sent, the obligation fails, one nack mail.
  4. A mutation check for each of the round-9 rules that lacks one.

Each new test goes red under the mutation that breaks its path.

Activity

  1. tps-flint commented on Sep 25, 2026

    @tps-flint
    ContributorAuthor

    Adding one item from Kern's #406 review: the deadline re-arm inside reconcileObligation is unpinned. Removing that one line leaves the whole suite green, because every tested restart re-arms through the yield handler or the dispatcher's else-branch. It is the only re-arm for a non-terminal record whose cur/ is gone, so add a test: restart with a non-terminal record and no cur/ entry re-arms its deadline and resolves.

  2. moved this to Triage in Office queueon Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Normal queue

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions