Skip to content

Verify the APPROVE evidence control on the deployed reviewer (real-container check, sandboxMountRoots) #473

Open

Description

@tps-flint

What is left after #462

#462 (merged as 561853f) makes APPROVE require host-recorded passing evidence. Two checks remain before the control can be relied on in the deployed reviewer:

  • Run the real-container evidence check (per-job-isolation-checks.sh records evidence and checks the record) on a host with Docker, against a good record, a wrong commit and a wrong key.
  • Configure sandboxMountRoots on the reviewer host to list every actual sandbox bind, and confirm an evidence store or key under any of them is refused (approval_evidence_reachable).

Until both are done, the plugin's evidence check is verified by unit and integration tests only.

Activity

  1. self-assigned this
    on Oct 2, 2026
  2. moved this to Triage in Office queueon Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions