fix: reuse existing id schema for hide recommendation - #918
Merged
Conversation
michaldrabik
commented
Aug 31, 2026
michaldrabik
commented
Collaborator
- currently generating invalid empty class param
seferturan
force-pushed
the
fix/recommended-id
branch
from
September 8, 2026 03:06
4ad5ba0 to
a7057e3
Compare
seferturan
approved these changes
Sep 8, 2026
seferturan
left a comment
seferturan
left a comment
Contributor
There was a problem hiding this comment.
Added a fixup to remove the dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.