prevent duplicate assembly steps - #50
Merged
rmehner merged 1 commit intoMay 30, 2018
Merged
Conversation
Collaborator
|
👍 This will be a breaking change tho, so we should have a CHANGELOG entry for this :) |
Member
|
+1 on CHANGELOG update, and I wonder if we want to bump the version to next major then also? |
Collaborator
Yup, it's a breaking change :) |
ifedapoolarewaju
force-pushed
the
prevent_duplicate_steps
branch
from
May 22, 2018 13:08
8d48f04 to
28878ff
Compare
Contributor
Author
rmehner
reviewed
May 22, 2018
| @@ -1,3 +1,7 @@ | |||
| ### 2.1.0 / ????-??-?? ### | |||
Collaborator
There was a problem hiding this comment.
3.0.0, since this is a breaking change.
ifedapoolarewaju
force-pushed
the
prevent_duplicate_steps
branch
from
May 22, 2018 13:12
28878ff to
c57ab75
Compare
Contributor
Author
|
@rmehner done, thank you |
Collaborator
|
Thank you @ifedapoolarewaju. I can push out the release later today :) |
Contributor
Author
|
@rmehner to merge or not to merge? |
Collaborator
|
Totally forgot about this. Will put this into my calendar to push out the release later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #27