Repository navigation
Conversation
Contributor License Agreement ❌This PR contains commits from author(s) with no linked GitHub account. All commits must be authored by a GitHub user so the CLA can be verified. Please ensure the git author email is associated with a GitHub account, or rewrite the commits with a linked identity. |
|
@ya1b please take a look at the CLA Assistant notice above. Are you able to execute this? |
cybermaggedon
left a comment
There was a problem hiding this comment.
Clean, minimal, each bare except replaced with the right specific exception.
|
Heads-up on the failing "Run tests" check: I think it's caused by the
Catching both keeps the current behaviour: except (LookupError, ValueError):I checked this locally with nltk 3.10.4: the ontology tests pass with that change. Side note: the Minor, optional: in |
Summary
json.JSONDecodeError.OSErrorwhen cleaning up temporary files.LookupErrorwhen the NLTK sentence tokenizer resource is unavailable.Testing
Closes #783