Skip to content

Submitting Comments to the whole page instead of the individual comment threads #30

Open
Open
Submitting Comments to the whole page instead of the individual comment threads#30

Description

@flemings
flemings
opened on Oct 11, 2017

Hi,

For some reason some of the comment links are submitting to the entire page instead of the individual comments. I'm confirming this by looking in the admin in Disqus. For example one that is working properly is https://mydomain.com/introductiondisqussion-7#comment-3562282982, an incorrect submission is https://mydomain.com/introduction#comment-3562298673. The unique "disqussion" identifier is missing in the submission.

I have checked that the properly is properly set on the "p" element, and on the "a" "disqussion-link" element. Including the other variables for the "a" element.

I have tracked it down to the "signedLink" property of the submission dialog. It appears in the iframe, in the script with the id "disqus-threadData."

Any thoughts on how I can properly update that value would be appreciated. I'm unsure why it works fine for some links on the page, but not all of them.

Thanks!
Sean

Activity

  1. tsi commented on Oct 15, 2017

    @tsi
    tsi
    on Oct 15, 2017
    Owner

    Could you reproduce the issue on codepen or somewhere we can inspect it?

  2. flemings commented on Oct 16, 2017

    @flemings
    flemings
    on Oct 16, 2017
    Author

    Hi I think I identified the issue. The CDN that serves the disqus count.js and other js files only updates every 30ish minutes, so when I was developing and making changes, disqus was not caught up. After I cleared all the erroneous comments and waited a while, things started working properly.

  3. flemings commented on Dec 1, 2017

    @flemings
    flemings
    on Dec 1, 2017
    Author

    Hi,

    I am encountering the issue again in production, except I can't use the solution of deleting the erroneous comments. You can view the issue here. The comments with all the same number are the issue. At the moment they are all at 19, but that could change.

    Any thoughts would be appreciated,
    Sean Fleming

  4. flemings commented on Dec 6, 2017

    @flemings
    flemings
    on Dec 6, 2017
    Author

    @tsi

  5. tsi commented on Dec 6, 2017

    @tsi
    tsi
    on Dec 6, 2017
    Owner

    Not sure, seems like the disqus_identifier and disqus_url are passing correctly, i.e. two different identifiers return the same comment thread.

    1. Can you get rid of any other JS issue on the page? uninav.min.js is throwing errors...
    2. Are you able to manually add data-disqus-identifier attribute to each paragraph? it might help.

  6. flemings commented on Dec 7, 2017

    @flemings
    flemings
    on Dec 7, 2017
    Author

    Hi @tsi ,

    I am not seeing any other js errors on the page. What browser are you using?
    I am not able to add them manually. They are generated based on what the content editor adds.
    Any other thoughts? I'm pretty sure that if I deleted the comments, it would fix it. Do you know if there is anyway to edit the comments in the disqus admin? I only see approve\delete.

    Thanks,
    Sean

  7. flemings
    closed this as completedon Dec 7, 2017
  8. flemings
    reopened this on Dec 7, 2017

  9. flemings commented on Jan 9, 2018

    @flemings
    flemings
    on Jan 9, 2018
    Author

    @tsi

  10. tsi commented on Jan 10, 2018

    @tsi
    tsi
    on Jan 10, 2018
    Owner

    @flemings sorry, this does seem weird, but I have no way of debugging internal Discuss quirks.
    If you can see any (reproducible) way in which this script needs improvement, let's set up a demo page and debug it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions