Handle TypeLoadException in config property scans - #5293
Merged
tig merged 2 commits intoMay 12, 2026
Merged
Conversation
tig
approved these changes
May 11, 2026
This was referenced May 21, 2026
This was referenced May 28, 2026
This was referenced Jun 15, 2026
This was referenced Jun 29, 2026
This was referenced Jul 13, 2026
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeLoadExceptionwhile checking foreign properties forConfigurationPropertyAttributeWhy
This supersedes the closed #5124 thread with the corrected proof.
The failure is not a plain
Assembly.GetTypes()repro on modern CoreCLR. The real downstream failure happens later in the same config-host scan, whenConfigProperty.Initialize()reflects over properties from foreign loaded assemblies andPropertyInfo.GetCustomAttribute(...)throws a plainTypeLoadExceptionwhile resolving broken custom-attribute metadata.The new test proves that exact shape with two fixture assemblies:
ConsumerLib.dllis compiled against a provider assembly that containsSystem.Diagnostics.CodeAnalysis.MemberNotNullWhenAttributeGetCustomAttribute(typeof(ConfigurationPropertyAttribute))on the consumer property throwsTypeLoadExceptionConfigProperty.ScanAssembliesForConfigPropertyHosts(...)now skips that foreign property and continues scanning later assembliesThat matches the downstream
MemberNotNullWhenAttributefailure we were seeing from loaded test-platform assemblies, but reduces it to a deterministic upstream test.Validation
dotnet restoredotnet build --no-restoredotnet test --project Tests/UnitTests.NonParallelizable/UnitTests.NonParallelizable.csproj --no-build -- --filter-class UnitTests.NonParallelizable.ConfigurationTests.ConfigPropertyAssemblyScanTestsdotnet test --project Tests/UnitTests.NonParallelizable/UnitTests.NonParallelizable.csproj --no-build -- --filter-namespace UnitTests.NonParallelizable.ConfigurationTestsdotnet test --project Tests/UnitTestsParallelizable/UnitTests.Parallelizable.csproj --no-build -- --filter-namespace ConfigurationTestsdotnet test --project Tests/UnitTests.NonParallelizable/UnitTests.NonParallelizable.csproj --no-builddotnet test --project Tests/UnitTestsParallelizable/UnitTests.Parallelizable.csproj --no-build