Fixes #5331. ListView.KeystrokeNavigator = null disables navigation - #5332
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08f61e59ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Convert KeystrokeNavigator from auto-property to one with a custom setter that automatically syncs the navigator's Collection with the current Source. This prevents a runtime issue where replacing the navigator after Source was set would leave the new navigator with an uninitialized collection. Add test proving reassignment after Source works correctly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tig
changed the title
BDisp
approved these changes
May 18, 2026
This was referenced May 21, 2026
This was referenced May 28, 2026
This was referenced Jun 15, 2026
This was referenced Jun 29, 2026
This was referenced Jul 13, 2026
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a unit test that verifies setting
ListView.KeystrokeNavigator = nulldisables keystroke navigation, as documented in the property's XML doc comment.The test:
KeystrokeNavigator = nullCloses #5331