docs(getting-started): use Accepted for side effects (canonical rule) - #5534
Merged
Merged
Conversation
Maintainer ruling: Accepted is canonical for side effects; Accepting only to cancel. getting-started.md said 'event handling uses the Accepting event', contradicting that. Reword to: use Accepted for side effects (button presses); use Accepting only to inspect/cancel (e.Handled = true). Both are public events on View; xrefs resolve. Part of #5525. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 25, 2026
This was referenced Jul 6, 2026
This was referenced Jul 13, 2026
This was referenced Jul 20, 2026
This was referenced Aug 3, 2026
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cascade of the maintainer ruling that
Acceptedis canonical for side effects (Acceptingonly to cancel).getting-started.mdsaid "event handling uses theAcceptingevent", which contradicts the rule. Reworded to:Acceptedfor side effects (e.g. handling a button press); the legacyAcceptevent is gone.Acceptingonly to inspect or cancel an action (e.Handled = true).Both are public events on
View(ViewBase/View.Command.cs), so the xrefs resolve.Part of #5525. (Companion: the templates were aligned in tui-cs/Terminal.Gui.templates#38. The cookbook examples were checked and are already correct — they use
Acceptingwithe.Handledfor genuine validation/cancel.)