chore!: improve data fetching & proposal form - #244
Merged
Merged
Conversation
helmturner
marked this pull request as draft
May 8, 2024 18:24
- unify/simplify fetching with `react-hook-forms` + `zod` validation - autogenerate client SDK/validators w/ `openapi-zod-client` & `zodios` - automatically populate user data from session - various API spec corrections/simplifications
- Asserts required user properties as non-null
helmturner
force-pushed
the
chore/data-fetching
branch
from
May 13, 2024 08:51
f60bd42 to
c48c40c
Compare
helmturner
marked this pull request as ready for review
May 13, 2024 09:46
helmturner
enabled auto-merge (rebase)
May 13, 2024 09:47
zenlex
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
nameandemailfields fromProposalForm.tsx#228This also gets us part of the way toward #239 by creating a pattern for handling fetch errors. Abstracting the patterns in
NewProposalFormErrorwould be the next step to closing it.Description
react-hook-forms+zodvalidationopenapi-zod-client&zodiosstringsuccessproperty toPOST /proposalsresponse schemaScreenshots (if appropriate):
Please review and suggest any further insights, improvements, or modifications needed.