Skip to content

Why do you have to redeclare the whole SASS Map? #23542

Closed

Description

Why do you have to redeclare the whole SASS Map when you re-map the variables?

I can't complete a build if I do this partially, I have to redeclare everything to make it work :(

Activity

  1. added
    cssSass sources or compiled CSS
    v4v4, the frozen docs on gh-pages
    on Aug 18, 2017
  2. bardiharborow commented on Aug 18, 2017

    @bardiharborow
    Contributor

    I assume you're referring to the maps added in #23260. The whole point is that you shouldn't have to redeclare the whole map, so if that's what's happening to you, can you share your code and what sass version you're using, and we'll try and figure out what's going on.

  3. pat270 commented on Aug 18, 2017

    @pat270
    Contributor

    The color variable names aren't defined because Sass parses top down. The color variables are defined in the bootstrap import, either copy all the color variables above $theme-colors or just set:

    $theme-colors: ( primary: #fd7e14 );
    
  4. mdo commented on Aug 18, 2017

    @mdo
    Member

    Demo I provided shows the map merging in action: https://codepen.io/emdeoh/pen/qXxYEO. Could be a Sass version issue?

  5. mdo commented on Aug 20, 2017

    @mdo
    Member

    Closing since this was resolved in our codebase.

  6. mdo commented on Aug 21, 2017

    @mdo
    Member

    No, I'm saying we fixed this issue since our beta in our v4-dev branch. Pull the latest and try that with your Sass compiler. If it doesn't work still, see if there's a difference in the Sass compilers and we can go from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cssSass sources or compiled CSSv4v4, the frozen docs on gh-pages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions