Skip to content

Modified theme colors map can not change color of some components #27801

Closed

Description

@ysds

From my comment: #27712 (comment).

About a way of changing the theme colors, the document explains as:
https://getbootstrap.com/docs/4.1/getting-started/theming/#modify-map

But, it actually is incorrect after #27378.

demo1: https://codepen.io/fellows3/pen/WYBbEM

$theme-colors: (
  "primary": green
);

demo2: https://codepen.io/fellows3/pen/ZmNYNd

$primary: green;

Activity

  1. added
    cssSass sources or compiled CSS
    v4v4, the frozen docs on gh-pages
    on Dec 10, 2018
  2. MartijnCuppens commented on Dec 14, 2018

    @MartijnCuppens
    Member

    I think we'll need to revert to the state before #27378 to avoid breaking changes.

    The way we define colors need to be reviewed at some point because we do not document what the purpose of $primary is in our documentation.

    Ref: #23908

  3. mdo commented on Dec 14, 2018

    @mdo
    Member

    I'm okay with reverting that other PR if it solves this problem for now. We can revisit how we use maps/variables with our v5 changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cssSass sources or compiled CSSv4v4, the frozen docs on gh-pages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions