Repository navigation
Add WriterT instances for supertypes of Monad - #628
Merged
Merged
Conversation
Current coverage is
|
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
stew
added a commit
that referenced
this pull request
Nov 15, 2015
Add WriterT instances for supertypes of Monad
19 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #620. There are still more
WriterTinstances that could be added, but this is already a sizable PR, so I thought getting in the supertypes ofMonadwould be a good chunk of work to split off.I've gone to fairly great lengths to ensure that implicit resolution works in various cases in the tests. Perhaps I've even gone a bit overboard, but I think that these tests are kind of necessary, because there are some inference issues with
Idthat are compounded by issues with type aliases. In fact I had to rework the prioritization hierarchy several times as these tests uncovered issues.