Skip to content

Fix incorrect effect_learner_objective in XGBRRegressor#504

Merged
jeongyoonlee merged 1 commit into
masterfrom
jeong/fix_501
Apr 30, 2022
Merged

Fix incorrect effect_learner_objective in XGBRRegressor#504
jeongyoonlee merged 1 commit into
masterfrom
jeong/fix_501

Conversation

@jeongyoonlee
Copy link
Copy Markdown
Collaborator

Proposed changes

This PR fixes #501.

Currently the default value of effect_learner_objective in XGBRRegressor is incorrectly set to rank:pairwise, which is for classification.

This PR updates it to reg:squarederror, and also splits the test for XGBRRegressor with sample_weights from one for BaseRClassifier with sample_weights.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

Copy link
Copy Markdown
Collaborator

@paullo0106 paullo0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeongyoonlee jeongyoonlee merged commit 1cd2906 into master Apr 30, 2022
@jeongyoonlee jeongyoonlee deleted the jeong/fix_501 branch April 30, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_BaseRClassifier_with_sample_weights fails with xgboost 1.6

2 participants