Skip to content

Exclude tests in setup.py#508

Merged
jeongyoonlee merged 1 commit into
uber:masterfrom
aldenrogers:setup_exclude_tests
May 2, 2022
Merged

Exclude tests in setup.py#508
jeongyoonlee merged 1 commit into
uber:masterfrom
aldenrogers:setup_exclude_tests

Conversation

@aldenrogers
Copy link
Copy Markdown
Contributor

Proposed changes

This fixes #507 by specifying in setup.py that tests should not be packaged.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Compare https://github.com/quiltdata/quilt/pull/2632/files for an example of a similar change elsewhere.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 2, 2022

CLA assistant check
All committers have signed the CLA.

@jeongyoonlee jeongyoonlee self-requested a review May 2, 2022 20:30
@aldenrogers
Copy link
Copy Markdown
Contributor Author

I'll need some time to confirm with my employer before signing the CLA

Copy link
Copy Markdown
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@jeongyoonlee jeongyoonlee merged commit 15dfbe3 into uber:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude tests package from built package

3 participants