Skip to content

Pin scikit-learn<1.6 until xgboost fix gets released#809

Merged
jeongyoonlee merged 1 commit into
masterfrom
jeong/808_fix_sklearn_tags_error
Dec 13, 2024
Merged

Pin scikit-learn<1.6 until xgboost fix gets released#809
jeongyoonlee merged 1 commit into
masterfrom
jeong/808_fix_sklearn_tags_error

Conversation

@jeongyoonlee
Copy link
Copy Markdown
Collaborator

Proposed changes

This PR fixes #808 by pinning scikit-learn to be <1.16 temporarily until xgboost fix gets released.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

@jeongyoonlee jeongyoonlee added the dependencies Pull requests that update a dependency file label Dec 13, 2024
@jeongyoonlee jeongyoonlee merged commit d369317 into master Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failures with scikit-learn==1.6

1 participant