Skip to content

add calibration example#816

Merged
jeongyoonlee merged 2 commits into
uber:masterfrom
ras44:ras44/calibration
Feb 24, 2025
Merged

add calibration example#816
jeongyoonlee merged 2 commits into
uber:masterfrom
ras44:ras44/calibration

Conversation

@ras44
Copy link
Copy Markdown
Collaborator

@ras44 ras44 commented Feb 22, 2025

Proposed changes

This adds a walkthrough of propensity model calibration to docs/examples.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@ras44 ras44 requested a review from jeongyoonlee February 22, 2025 12:23
@jeongyoonlee
Copy link
Copy Markdown
Collaborator

Thanks for adding the example notebook for calibration. Can you also add it to the example page at https://github.com/uber/causalml/blob/master/docs/examples.rst?

Copy link
Copy Markdown
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jeongyoonlee jeongyoonlee merged commit 04604d0 into uber:master Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants