Support for using URL-encoded paths as group or project ids#550
Merged
Conversation
Toa741
reviewed
Oct 25, 2023
PMExtra
marked this pull request as draft
October 25, 2023 15:15
PMExtra
force-pushed
the
feature/string-id
branch
from
October 27, 2023 08:14
a667bf5 to
ac00015
Compare
PMExtra
marked this pull request as ready for review
October 27, 2023 08:15
Contributor
Author
|
I changed the existing constructor to only support the new Maybe we should unify the client implementations classes to be |
PMExtra
force-pushed
the
feature/string-id
branch
from
October 30, 2023 01:38
ac00015 to
b42eedb
Compare
Toa741
reviewed
Oct 30, 2023
PMExtra
commented
Oct 30, 2023
PMExtra
force-pushed
the
feature/string-id
branch
from
October 31, 2023 01:25
76fd858 to
11e2c1e
Compare
meziantou
removed their request for review
November 2, 2023 18:37
Contributor
Author
|
@Toa741 I think it's ready to merge. Please let me know if there is anything else. |
Contributor
Alright :), will make a final review |
Toa741
reviewed
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.gitlab.com/ee/api/rest/index.html#namespaced-path-encoding