Skip to content

Add async CRUD methods to IProjectClient#655

Merged
Toa741 merged 5 commits into
ubisoft:mainfrom
belcher-rok:belcher-projectclient-async
Apr 10, 2024
Merged

Add async CRUD methods to IProjectClient#655
Toa741 merged 5 commits into
ubisoft:mainfrom
belcher-rok:belcher-projectclient-async

Conversation

@belcher-rok

@belcher-rok belcher-rok commented Apr 4, 2024

Copy link
Copy Markdown
Contributor
  • Adds async CRUD methods to IProjectClient.
  • Improves the Mock ProjectClient to better emulate actual GitLab behavior:
    • Project Create must specify Name or Path.
    • Auto-generate missing Path from Name, and vice-versa.
    • Cannot create project with duplicate Name (case-sensitive).
    • Cannot create project with duplicate Path (case-INsensitive).
    • Project.BuildTimeout is in seconds, not minutes.
    • GitLab ignores ProjectCreate.DefaultBranch unless ProjectCreate.InitializeWithReadme is true.
    • Project.ToClientProject() did not populate NameWithNamspace.
    • Project.FullName contains spaces around the slash separator.
  • Added tests to verify GitLab and Mock behaviors.

Also improve the Mock ProjectClient to better emulate actual GitLab behavior.
@belcher-rok
belcher-rok requested a review from a team as a code owner April 4, 2024 00:58
@belcher-rok
belcher-rok requested review from Toa741 and removed request for a team April 4, 2024 00:58
@belcher-rok

Copy link
Copy Markdown
Contributor Author

@Toa741 Anything I can do to help move this along?

Comment thread NGitLab.Mock/Config/GitLabHelpers.cs Outdated
@Toa741

Toa741 commented Apr 8, 2024

Copy link
Copy Markdown
Contributor

@Toa741 Anything I can do to help move this along?

Hey John :), I was on vacation, everything looks good, just had one question regarding the Project init in the mock

@Toa741
Toa741 merged commit 1e153b9 into ubisoft:main Apr 10, 2024
@belcher-rok
belcher-rok deleted the belcher-projectclient-async branch April 11, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants