Skip to content

added missing page parameter in event query#667

Merged
louis-z merged 1 commit into
ubisoft:mainfrom
TheVVaS:fix/missing-page-parameter-in-event-query
May 2, 2024
Merged

added missing page parameter in event query#667
louis-z merged 1 commit into
ubisoft:mainfrom
TheVVaS:fix/missing-page-parameter-in-event-query

Conversation

@TheVVaS

@TheVVaS TheVVaS commented May 2, 2024

Copy link
Copy Markdown
Contributor

Somehow only per_page exists, added missing page

@TheVVaS
TheVVaS requested a review from a team as a code owner May 2, 2024 11:41
@TheVVaS
TheVVaS requested review from Toa741 and removed request for a team May 2, 2024 11:41
@louis-z

louis-z commented May 2, 2024

Copy link
Copy Markdown
Member

Thanks @TheVVaS for your contribution. You'll need to document the changes you made to the public API. The easiest way of doing that is to use the Visual Studio refactoring feature:

image

@TheVVaS

TheVVaS commented May 2, 2024

Copy link
Copy Markdown
Contributor Author

@louis-z I hope I did it right this time

@louis-z
louis-z merged commit 9e7e8f3 into ubisoft:main May 2, 2024
@TheVVaS
TheVVaS deleted the fix/missing-page-parameter-in-event-query branch May 3, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants