Skip to content

fix: support groq compound defaults - #3281

Open
AbdullahFageeh wants to merge 1 commit into
ultraworkers:mainfrom
AbdullahFageeh:oz/groq-compound-defaults
Open

fix: support groq compound defaults#3281
AbdullahFageeh wants to merge 1 commit into
ultraworkers:mainfrom
AbdullahFageeh:oz/groq-compound-defaults

Conversation

@AbdullahFageeh

Copy link
Copy Markdown

Summary

  • route groq/ model IDs through the OpenAI-compatible client
  • add Groq token-limit metadata for compound and llama 4 scout models
  • disable local tool injection for compound models and add regression coverage

Validation

  • cargo test --manifest-path rust/Cargo.toml groq_ --workspace
  • cargo build --manifest-path rust/Cargo.toml --release --workspace
  • zsh -lic 'mkdir -p /Users/abdullah/tools/claw-smoke && claw --cwd /Users/abdullah/tools/claw-smoke --permission-mode read-only prompt "Reply exactly READY"'

Conversation: https://app.warp.dev/conversation/9443f8d1-a24e-42ea-9f04-0dd8bf608859

Co-Authored-By: Oz oz-agent@warp.dev

Route groq-prefixed models through the OpenAI-compatible client,
apply Groq token-limit metadata, and skip local tool injection for
compound models.

Add regression coverage for routing, token limits, and compound
local-tool behavior.

Co-Authored-By: Oz <oz-agent@warp.dev>
@AbdullahFageeh
AbdullahFageeh deleted the oz/groq-compound-defaults branch July 31, 2026 19:06
@AbdullahFageeh
AbdullahFageeh restored the oz/groq-compound-defaults branch July 31, 2026 19:13
@1716775457damn

Copy link
Copy Markdown

Nice fix. Routing groq models through the OpenAI-compatible client is the right approach for maintainability. The compound model token-limit metadata is a detail that's easy to overlook but important for correct truncation behavior. The regression coverage for local tool injection is also a good defensive measure — compound models with tool use can produce surprising behavior without it.

@1716775457damn

Copy link
Copy Markdown

Nice catch — Groq compound defaults were silently ignored before. The explicit handling makes provider behavior predictable across different model families.

@1716775457damn

Copy link
Copy Markdown

Nice work on the Groq integration. The compound model handling with disabled local tool injection looks correct — compound models typically don't support tool calling the same way standard models do. One thing to verify: the token-limit metadata for llama-4-scout should be cross-checked against the latest Groq API docs, as their limits have shifted between model versions in the past. Otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants