Complete pm-utd6 and add MCP compact projection integration coverage by unbraind · Pull Request #188 · unbraind/pm-cli

unbraind · 2026-06-09T21:12:23Z

Summary

complete active pm-utd6 execution work with refreshed evidence, docs clarification for optional governance-audit dedupe-audit, and @sentry/node dependency bump to ^10.57.0
add MCP integration assertions for narrow tools: pm_context brief/deep behavior, pm_plan compact-vs-deep show projection, and pm_contracts flagsOnly compact command projection
update pm tracker items/history (pm-utd6, pm-8d00) with linked files/tests, manual smoke evidence, GH/Sentry/security snapshots, and full verification records

Test plan

Add explicit MCP integration assertions for pm_context, pm_plan, and pm_contracts compact/deep projection behavior so agent-facing payload guarantees stay stable while completing the active pm-utd6 + pm-8d00 workstream with refreshed dependency/docs and full verification evidence.

gemini-code-assist · 2026-06-09T21:12:27Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

sourcery-ai

Sorry @unbraind, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

unbraind · 2026-06-09T21:12:36Z

@codex review\n/gemini review\n@gemini-code-assist review

coderabbitai · 2026-06-09T21:12:39Z

Warning

Review limit reached

@unbraind, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 37 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f1113cf4-b8ef-44a7-a70d-0576b8f2d8fa

📥 Commits

Reviewing files that changed from the base of the PR and between 5ea372d and 364f6dd.

📒 Files selected for processing (5)

.agents/pm/chores/pm-8d00.toon
.agents/pm/history/pm-8d00.jsonl
tests/helpers/mcp-context-depth.ts
tests/integration/mcp-dynamic-package-actions.spec.ts
tests/integration/mcp-handshake.spec.ts

📝 Walkthrough

Walkthrough

This PR adds integration test coverage for MCP tools (pm_context, pm_plan, pm_contracts) verifying depth projections and command flags, updates the Sentry dependency to ^10.57.0, clarifies documentation for an optional dedupe-audit command, and records full task and chore metadata tracking this work across multiple verification cycles.

Changes

MCP Integration Tests and Task Metadata

Layer / File(s)	Summary
pm_context Depth Projection Tests `tests/integration/mcp-handshake.spec.ts`	New integration test exercising `pm_context` MCP tool with default brief projection (summary, low_level items, no description/body) and explicit deep projection (depth override, updated summary/low_level shape).
pm_plan and pm_contracts Integration Tests `tests/integration/mcp-dynamic-package-actions.spec.ts`	Expanded assertions for `pm_context` brief/deep projections in dynamic actions; `pm_plan` creation/show tests validating steps omitted by default and included with depth: "deep"; `pm_contracts` test verifying flagsOnly option returns command flags without runtime_schema.
Dependency and Documentation Updates `package.json`, `docs/COMMANDS.md`	Sentry dependency bump ^10.56.0 → ^10.57.0; documentation marks `dedupe-audit` as optional from `governance-audit` package with example install command.
Task pm-utd6 Definition and History `.agents/pm/tasks/pm-utd6.toon`, `.agents/pm/history/pm-utd6.jsonl`	New task record tracking pm-utd6 lifecycle (open → claimed → in_progress); history log records dependency/doc changes, verification evidence (closed issues, build/coverage, security snapshots, credential-hygiene pass), extended verification commands across continuation cycles, and final baseline confirmation.
Chore pm-8d00 and Accidental Item Cleanup `.agents/pm/chores/pm-8d00.toon`, `.agents/pm/history/pm-8d00.jsonl`, `.agents/pm/history/pm-98d1.jsonl`, `.agents/pm/history/pm-jhr0.jsonl`, `.agents/pm/extensions/.managed-extensions.json`	Chore status updated to in_progress with test coverage references for mcp-handshake and mcp-dynamic-package-actions specs; auxiliary history records for accidentally created items pm-98d1 and pm-jhr0 (create/delete pairs for cleanup); managed-extensions timestamp updated.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly describes the main objectives of the changeset: completing pm-utd6 work and adding MCP integration test coverage for compact projections.
Description check	✅ Passed	The description is clearly related to the changeset, providing a well-organized summary of changes (pm-utd6 completion, dependency bump, MCP integration tests, tracker updates) with comprehensive test results.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2026-06-09T21:12:40Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

chatgpt-codex-connector · 2026-06-09T21:12:47Z

To use Codex here, create a Codex account and connect to github.

coderabbitai

🧹 Nitpick comments (1)

tests/integration/mcp-dynamic-package-actions.spec.ts (1)

783-870: ⚡ Quick win

Consolidate duplicated pm_context depth test.

This test is nearly identical to lines 135-214 in tests/integration/mcp-handshake.spec.ts. Consider extracting the shared test logic into a reusable helper function to reduce duplication and ensure consistency.

♻️ Refactoring approach

Create a shared helper in tests/helpers/:

// tests/helpers/mcp-context-depth.ts
export async function testPmContextDepthProjection(context: PmTestContext) {
  // Shared test logic here
}

Then call it from both test files:

it("defaults pm_context to brief depth and supports explicit deeper projections", async () => {
  await withTempPmPath(testPmContextDepthProjection);
});

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/mcp-dynamic-package-actions.spec.ts` around lines 783 -
870, Extract the duplicated pm_context depth test into a shared helper function
(e.g., testPmContextDepthProjection) and call it from both specs; move the
shared logic that uses withTempPmPath, create CLI invocation, handleRequest
calls for "pm_context", and the subsequent assertions into
tests/helpers/mcp-context-depth.ts so both tests simply call await
withTempPmPath(testPmContextDepthProjection); ensure the helper accepts the
PmTestContext and performs the same assertions (checking brief default, deep
option, id/title/status assertions) and references handleRequest and pm_context
consistently.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/integration/mcp-dynamic-package-actions.spec.ts`:
- Around line 783-870: Extract the duplicated pm_context depth test into a
shared helper function (e.g., testPmContextDepthProjection) and call it from
both specs; move the shared logic that uses withTempPmPath, create CLI
invocation, handleRequest calls for "pm_context", and the subsequent assertions
into tests/helpers/mcp-context-depth.ts so both tests simply call await
withTempPmPath(testPmContextDepthProjection); ensure the helper accepts the
PmTestContext and performs the same assertions (checking brief default, deep
option, id/title/status assertions) and references handleRequest and pm_context
consistently.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 9a9450da-099b-4e9c-a0b7-debb96decfb9

📥 Commits

Reviewing files that changed from the base of the PR and between cae68cd and 5ea372d.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (11)

.agents/pm/chores/pm-8d00.toon
.agents/pm/extensions/.managed-extensions.json
.agents/pm/history/pm-8d00.jsonl
.agents/pm/history/pm-98d1.jsonl
.agents/pm/history/pm-jhr0.jsonl
.agents/pm/history/pm-utd6.jsonl
.agents/pm/tasks/pm-utd6.toon
docs/COMMANDS.md
package.json
tests/integration/mcp-dynamic-package-actions.spec.ts
tests/integration/mcp-handshake.spec.ts

Extract duplicated pm_context brief/deep projection checks into a shared helper so both MCP integration specs stay consistent and future projection contract updates only require one test-logic change.

unbraind · 2026-06-09T21:21:47Z

Pushed follow-up for CodeRabbit nitpick: extracted shared pm_context projection assertions into tests/helpers/mcp-context-depth.ts and reused in both integration specs.\n\n@codex review\n/gemini review\n@gemini-code-assist review

gemini-code-assist · 2026-06-09T21:21:51Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

chatgpt-codex-connector · 2026-06-09T21:21:54Z

To use Codex here, create a Codex account and connect to github.

Persist final merge evidence and closure metadata for the completed workstream so both tracker items are terminal with explicit resolution, expected/actual outcomes, and release records tied to PR #188.

sourcery-ai Bot reviewed Jun 9, 2026

View reviewed changes

coderabbitai Bot reviewed Jun 9, 2026

View reviewed changes

refactor(test): share pm_context MCP projection assertions

364f6dd

Extract duplicated pm_context brief/deep projection checks into a shared helper so both MCP integration specs stay consistent and future projection contract updates only require one test-logic change.

unbraind merged commit aecae89 into main Jun 9, 2026
15 checks passed

unbraind deleted the feat/utd6-mcp-compact-coverage branch June 9, 2026 21:28

This was referenced Jun 10, 2026

Expand SDK context and mutation primitives #198

Merged

pm context --depth full + --parent subtree scope; pm list --no-truncate (GH-156, GH-154, GH-155, GH-223) #234

Merged

This was referenced Jun 25, 2026

Fix protected-main auto-release token and contracts namespaces #366

Merged

Fix Windows background test-run signal coverage #377

Merged

Refresh Sentry release dependencies #384

Merged

coderabbitai Bot mentioned this pull request Jul 8, 2026

Add agent list windows and contracts summary #483

Merged

coderabbitai Bot mentioned this pull request Jul 25, 2026

feat(sdk): extensible agent identity and model provenance #713

Merged

Navigation Menu

Repository navigation

Complete pm-utd6 and add MCP compact projection integration coverage - #188

Complete pm-utd6 and add MCP compact projection integration coverage#188
unbraind merged 2 commits into
mainfrom
feat/utd6-mcp-compact-coverage

unbraind commented Jun 9, 2026

Uh oh!

gemini-code-assist Bot commented Jun 9, 2026

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

unbraind commented Jun 9, 2026

Uh oh!

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Estimated code review effort

Uh oh!

gemini-code-assist Bot commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 9, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

unbraind commented Jun 9, 2026

Uh oh!

gemini-code-assist Bot commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 9, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

unbraind commented Jun 9, 2026

Summary

Test plan

Uh oh!

gemini-code-assist Bot commented Jun 9, 2026

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

unbraind commented Jun 9, 2026

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Estimated code review effort

Uh oh!

gemini-code-assist Bot commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 9, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

unbraind commented Jun 9, 2026

Uh oh!

gemini-code-assist Bot commented Jun 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 9, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading