Skip to content

feat(sdk): scaffold importers package starters #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unbraind merged 3 commits into from
Jun 22, 2026
Merged

feat(sdk): scaffold importers package starters #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df7e29d
feat(sdk): scaffold importers package starters
unbraind Jun 22, 2026
02285d3
fix(sdk): align scaffold importer action names
unbraind Jun 22, 2026
e73810f
fix(reviews): address importer scaffold PR feedback
unbraind Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions .agents/pm/features/pm-j5az.toon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
id: pm-j5az
title: Add importers package scaffold and dependency-maintenance closeout
description: "Continue SDK/package platform maturity by adding a first-class pm package init --capability importers scaffold with runnable SDK tests, documenting the package-author flow, and folding current GitHub dependency/security findings into the same implementation lane. Duplicate check: searched all statuses for package init capability importers scaffold registerImporter registerExporter; related work pm-nhby, pm-pwai, pm-13bn, and pm-7qjk is closed and does not cover an importers scaffold."
type: Feature
status: closed
priority: 1
tags[4]: agent-ux,"area:packages","area:sdk",github-deps
created_at: "2026-06-22T07:37:43.033Z"
updated_at: "2026-06-22T08:22:46.245Z"
author: codex-sdk-cli-continuation
parent: pm-ugqx
resolution: Implemented and verified a first-class importers scaffold plus dependency maintenance bundle.
expected_result: "Package authors can run pm package init --capability importers to get a runnable import/export starter with SDK tests, docs, completions, and dependency-maintenance updates remain green."
actual_result: "The importers scaffold generates command-safe import/export commands, declares importers plus schema for flag metadata, passes generated npm test and installed CLI temp smoke, updates docs/completions/tests, applies compatible Dependabot updates, and passes release gates with literal 100/100/100/100 coverage."
comments[6]{created_at,author,text}:
"2026-06-22T07:43:42.762Z",codex-sdk-cli-continuation,"Investigation note: GitHub triage found open Dependabot PRs #334 checkout v7.0.0, #335 pnpm/action-setup v6.0.9, #336 softprops/action-gh-release v3.0.1, and #337 @types/node 26.0.0; no open GitHub issues and no open Dependabot security alerts. pnpm audit --audit-level moderate reported no known vulnerabilities. Duplicate check searched all statuses for importers package scaffolding; related pm-nhby, pm-pwai, pm-13bn, and pm-7qjk are closed and do not cover an importers scaffold."
"2026-06-22T07:48:30.502Z",codex-sdk-cli-continuation,"Evidence: focused tests passed after scaffold fixes: node scripts/run-tests.mjs test -- tests/unit/extensions/extension-command.spec.ts tests/unit/commands/completion-command.spec.ts tests/integration/ci-workflow-contract.spec.ts (3 files, 206 tests). Manual temp smoke passed in /tmp/tmp.JZpoMLa3r6 with isolated PM_GLOBAL_PATH: pm init demo --force, pm package init ./starter-importers --capability importers, npm install --no-save local checkout, npm test, pm install ./starter-importers --project, pm starter importers items import --source tickets --json, and pm starter importers items export --destination archive --json. Install activation diagnostics reported failed_count 0 and command discovery exposed starter importers items import/export/ping."
"2026-06-22T07:59:36.520Z",codex-sdk-cli-continuation,"Evidence: repo-wide gates passed. node scripts/run-tests.mjs coverage reported 242 files / 4834 tests and literal 100/100/100/100 coverage (Statements 30546/30546, Branches 23823/23823, Functions 5107/5107, Lines 29341/29341). pnpm quality:docs-skills passed. pnpm quality:static passed. pm validate --check-resolution --check-history-drift returned ok with pre-existing validate_resolution_missing_fields:227 warning and history_drift ok. pnpm changelog:pm:check passed with pm-changelog 2026.6.20 and CHANGELOG.md unchanged. pnpm contracts:check passed. pnpm audit --audit-level moderate reported no known vulnerabilities. pnpm security:scan found no credential-like secrets. sentry-telemetry-gate best-effort passed: Sentry 0 critical/high blockers over 14 days, telemetry finish_error_rate_pct 1.23, failures_without_error_code_rows 0. pnpm release:gates passed, including npx packed package smoke and package-first dogfood."
"2026-06-22T08:00:07.838Z",codex-sdk-cli-continuation,"Dependency note: after applying @types/node 26.0.0, pnpm outdated --format json only reports commander 15.0.0. npm metadata for commander@15.0.0 requires node >=22.12.0, so it is intentionally deferred because pm-cli still supports node >=20 and CI validates Node 20."
"2026-06-22T08:12:16.385Z",codex,"Review follow-up: applied Gemini feedback on PR #338 by generating importer/exporter action ids with the same space-separated command path shown to users instead of hyphenated internal ids. Re-ran focused tests and build after the patch: node scripts/run-tests.mjs test -- tests/unit/extensions/extension-command.spec.ts tests/unit/commands/completion-command.spec.ts tests/integration/ci-workflow-contract.spec.ts passed 206 tests; pnpm build passed. Manual temp smoke after the review fix passed in isolated temp directories: pm init demo --force, package init ./starter-importers --capability importers, npm install --no-save checkout, npm test, project install, starter importers items import --source tickets, and starter importers items export --destination archive all succeeded with expected importer/exporter results."
"2026-06-22T08:22:46.245Z",codex,"Review follow-up: addressed CodeRabbit comments on PR #338. Added persist-credentials: false to the release workflow checkout, restored @types/node to the Node 20 typings line with lockfile consistency, fixed package/extension importers help examples to use matching my-sync paths, and made src/cli.ts compile-cache access structurally typed so Node 20 typings pass while newer Node versions keep the optional optimization. Verification passed: node scripts/run-tests.mjs test -- tests/integration/ci-workflow-contract.spec.ts tests/integration/release-automation-contract.spec.ts tests/unit/commands/completion-command.spec.ts tests/unit/extensions/extension-command.spec.ts (4 files, 220 tests); pnpm --store-dir=<pnpm-store> build; pnpm --store-dir=<pnpm-store> typecheck; pnpm --store-dir <pnpm-store> install --frozen-lockfile."
files[16]{path,scope,note}:
.github/workflows/auto-release.yml,project,Apply current auto-release workflow dependency pin updates
.github/workflows/ci.yml,project,Apply current CI workflow dependency pin updates
.github/workflows/codeql.yml,project,Apply checkout action dependency pin update
.github/workflows/docs.yml,project,Apply workflow dependency pin updates
.github/workflows/nightly.yml,project,Apply workflow dependency pin updates
.github/workflows/release.yml,project,Apply release workflow dependency pin updates
CHANGELOG.md,project,Package-owned changelog regenerated after closing pm-j5az
package.json,project,Update @types/node dev dependency
pnpm-lock.yaml,project,Generated lockfile for @types/node update
src/cli.ts,project,Keep optional Node compile-cache optimization type-safe against Node 20 typings
src/cli/commands/completion.ts,project,Expose importers capability in shell completions
src/cli/commands/extension/scaffold.ts,project,Add importers-capability scaffold runtime and generated SDK sample tests
src/cli/help-content.ts,project,Advertise importers package/extension scaffold examples
tests/integration/ci-workflow-contract.spec.ts,project,Keep release workflow pinned action contract current
tests/unit/commands/completion-command.spec.ts,project,Cover importers completion value
tests/unit/extensions/extension-command.spec.ts,project,Cover importers package and extension scaffolds
tests[7]{command,path,scope,timeout_seconds,pm_context_mode,env_set,env_clear,shared_host_safe,assert_stdout_contains,assert_stdout_regex,assert_stderr_contains,assert_stderr_regex,assert_stdout_min_lines,assert_json_field_equals,assert_json_field_gte,note}:
node scripts/run-tests.mjs coverage,null,project,900,null,null,null,null,null,null,null,null,null,null,null,null
node scripts/run-tests.mjs test -- tests/unit/extensions/extension-command.spec.ts tests/unit/commands/completion-command.spec.ts tests/integration/ci-workflow-contract.spec.ts,null,project,240,null,null,null,null,null,null,null,null,null,null,null,null
pm validate --check-resolution --check-history-drift,null,project,300,null,null,null,null,null,null,null,null,null,null,null,null
pnpm build,null,project,240,null,null,null,null,null,null,null,null,null,null,null,null
"pnpm quality:docs-skills",null,project,300,null,null,null,null,null,null,null,null,null,null,null,null
"pnpm quality:static",null,project,300,null,null,null,null,null,null,null,null,null,null,null,null
"pnpm release:gates",null,project,900,null,null,null,null,null,null,null,null,null,null,null,null
docs[3]{path,scope,note}:
CHANGELOG.md,project,Release changelog updated by pm-changelog after closure
docs/EXTENSIONS.md,project,Document importers scaffold in package authoring flow
docs/SDK.md,project,Document importers package scaffold SDK helpers
close_reason: "Implemented importers package scaffold, dependency-maintenance updates, docs/tests, temp-project smoke, 100/100/100/100 coverage, release gates, changelog/contracts/security/Sentry/telemetry validation."
body: ""
Loading