Repository navigation
fix(windows): harden telemetry detached-spawn + fix runtime-loader colon-path (Windows nightly Node 24, GH-363) - #365
Conversation
…lon-path (GH-363, pm-xaib) The Windows nightly (windows-latest) went red on the 2026-06-24 Node 20 -> 24 matrix bump with three deterministic symptoms. Fix all three and expand the per-PR windows-regression Node 24 oracle so the classes fail pre-merge. 1. Telemetry detached-spawn unhandled error -> vitest worker crash (root cause of the long-standing GH-348 "Worker forks emitted error / Worker exited unexpectedly" teardown crash, pm-2kkl). scheduleTelemetryFlush launched the detached flush worker via spawn() with no child.on("error") listener, so an async spawn failure (locked-down Windows runner / EACCES / missing runner) re-throws as an uncaught exception that crashes the foreground CLI and the vitest fork worker. The sibling search dispatchRefreshChild already had this guard; telemetry was the lone outlier. Added child.on("error") that releases the spawn gate. The unit test that exercised this also launched a real, network-touching, untracked node flush child (orphaned on Windows); it now mocks node:child_process like background-refresh.spec.ts, plus a focused regression test that emits an async 'error' and asserts the gate is released. 2. runtime-loaders.spec.ts colon-path ENOENT (pm-beads + pm-todos): the path normalization fixture synthesized a literal "C:\pm\project" segment; the colon is reserved on Windows so mkdir raised ENOENT. The fixture is now platform-aware and exercises the loader's backslash-normalizing branch identically on both platforms with no coverage change. 3. cli.integration.spec.ts packed-npm install: surface the install stderr/stdout in the assertion so the Windows-only npm .cmd shell-spawn / tar / junction failure is diagnosable in CI rather than a bare "expected 1 to be 0". CI: windows-regression (Node 24) now also runs runtime-loaders.spec.ts, telemetry-runtime.spec.ts, and the packed-npm-extension install case; the ci-workflow-contract spec locks the new commands. Full suite green (5096 tests, 100/100/100/100 coverage); typecheck, static and docs/skills gates pass; manual sandbox smoke test of core flows + the telemetry detached-flush path verified clean with zero orphan children. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PY9Gnrmrh9EVxGmpBVAv9j
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reached
More reviews will be available in 6 minutes and 32 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughThe PR updates telemetry flush handling to ignore asynchronous child-process spawn errors, normalizes npm pack and file-alias resolution to native filesystem paths, expands Windows regression coverage for runtime-loader and packed-extension tests, and appends matching GH-348/GH-363 issue history updates. ChangesWindows regression bundle
Sequence Diagram(s)sequenceDiagram
participant scheduleTelemetryFlush
participant spawn
participant detachedFlushWorker
scheduleTelemetryFlush->>spawn: spawn detached flush worker
spawn-->>detachedFlushWorker: child process
detachedFlushWorker-->>scheduleTelemetryFlush: error event
scheduleTelemetryFlush->>scheduleTelemetryFlush: release flush gate
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
|
/gemini review |
|
@codex review |
✅ Action performedFull review finished. |
|
To use Codex here, create a Codex account and connect to github. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses several Windows-specific test and runtime issues (GH-348 and GH-363). Specifically, it adds an asynchronous error handler to the detached telemetry flush spawn in src/core/telemetry/runtime.ts to prevent uncaught exceptions from crashing vitest workers during teardown. Additionally, it mocks node:child_process in the telemetry unit tests to avoid spawning real, lingering processes, fixes a Windows path-creation issue in runtime-loaders.spec.ts by avoiding reserved colon characters, improves diagnostics for CLI installation failures, and expands the CI workflow contract to cover these tests. There are no review comments provided, so I have no feedback to provide on the review itself.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request addresses several Windows-specific test and runtime issues (GH-363 and GH-348). Key changes include adding an 'error' event listener to the detached telemetry flush spawn process in src/core/telemetry/runtime.ts to prevent unhandled exceptions from crashing vitest workers on teardown, mocking node:child_process in telemetry tests to avoid orphan processes, and resolving a Windows path creation issue in runtime-loaders.spec.ts by avoiding reserved colon characters. Additionally, CLI integration tests now provide more detailed error diagnostics on failure. Feedback points out that while the CI workflow contract test was updated to expect new test commands, the actual .github/workflows/ci.yml file was not modified in this PR, which will likely cause the CI build to fail.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "run: node scripts/run-tests.mjs test -- tests/unit/cli/cli-main-errors.spec.ts tests/unit/core/schema/runtime-schema-path-win32-guard.spec.ts tests/unit/helpers/scriptModule.spec.ts tests/unit/scripts/ tests/unit/packages/runtime-loaders.spec.ts tests/unit/core/telemetry/telemetry-runtime.spec.ts", | ||
| "run: node scripts/run-tests.mjs test -- tests/integration/cli.integration.spec.ts -t \"installs runtime dependencies for packed npm package extensions\"", | ||
| ]); | ||
| expect(ciWorkflow.match(/PM_RUN_TESTS_SKIP_BUILD: "1"/g)?.length).toBe(2); | ||
| expect(ciWorkflow.match(/PM_RUN_TESTS_SKIP_BUILD: "1"/g)?.length).toBe(3); |
There was a problem hiding this comment.
The contract test has been updated to expect the new test commands and three occurrences of PM_RUN_TESTS_SKIP_BUILD: "1" in .github/workflows/ci.yml. However, the actual .github/workflows/ci.yml file is not modified in this pull request. Please ensure that .github/workflows/ci.yml is updated to match these new contract expectations, otherwise the CI build will fail.
…cs resolve (GH-363) Windows-regression (Node 24) surfaced the real packed-npm-extension install failure via the new diagnostic: `npm pack` received `name@file:///C:/Users/RUNNER%7E1/...` and opened the literal `RUNNER%7E1` directory, failing ENOENT. pathToFileURL percent-encodes the Windows 8.3 `~` short name (and spaces -> %20); pm passed that encoded file URL straight to npm, which opens it literally. This is a real cross-platform bug — reproduced on Linux with a space-containing path (`pm install npm:file:///…/pm%20space/pkg`). resolveNpmPackSpec and normalizeNpmLocalFileAliasSpec now hand npm pack a NATIVE decoded filesystem path (via fileURLToPath) instead of a percent-encoded file URL, and decode `file:///abs` alias targets (previously bailed on the `//` prefix) while leaving `file://host/share` UNC specs untouched. The resolver contract tests assert native paths, plus a regression asserting an encoded `%20`/`%7E` alias decodes (no `%` survives). Verified end-to-end on Linux: a space-containing local package install now succeeds where it previously ENOENT'd. Full suite green (5096 tests, 100/100/100/100 coverage); typecheck, static and docs/skills gates pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PY9Gnrmrh9EVxGmpBVAv9j
|
Pushed 6e9cc0c: the real packed-npm-extension install failure is now root-caused and fixed. The Windows-regression diagnostic revealed Re: the earlier Please re-review the full diff: |
|
To use Codex here, create a Codex account and connect to github. |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Code Review
This pull request addresses several Windows-specific nightly test failures and a long-standing teardown crash. Specifically, it updates install-sources.ts to pass native filesystem paths instead of percent-encoded file URLs to npm pack to prevent ENOENT errors on paths containing spaces or ~ characters. It also hardens the detached telemetry flush spawn by adding an asynchronous error listener to prevent vitest worker crashes, mocks child processes in telemetry tests to avoid orphan processes, and fixes a test fixture directory creation failure on Windows. Feedback on these changes highlights a potential runtime crash on Windows when calling fileURLToPath with root-relative paths that do not start with a drive letter, suggesting a try-catch fallback.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| // Windows 8.3 `~` short name escaped to `%7E` — fails ENOENT on every platform | ||
| // (GH-363). `file:///abs` and `file:/abs` are absolute URLs decoded via | ||
| // fileURLToPath; a bare relative target resolves against cwd. | ||
| const absolutePath = target.startsWith("/") ? fileURLToPath(`file:${target}`) : path.resolve(cwd, target); |
There was a problem hiding this comment.
On Windows, calling fileURLToPath with a URL path that does not start with a drive letter (e.g., file:/Users/runner) throws a TypeError [ERR_INVALID_FILE_URL_PATH]. Since target can be a root-relative path starting with a single / on Windows, calling fileURLToPath directly here without a guard can crash the CLI process.
To prevent this runtime crash, wrap the fileURLToPath call in a try-catch block and fall back to path.resolve(cwd, target) if parsing fails.
let absolutePath: string;
try {
absolutePath = target.startsWith("/") ? fileURLToPath("file:" + target) : path.resolve(cwd, target);
} catch {
absolutePath = path.resolve(cwd, target);
}![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/unit/core/telemetry/telemetry-runtime.spec.ts`:
- Around line 1743-1770: Restore all test-mutated telemetry env vars in the
try/finally cleanup for startTelemetryCommand in telemetry-runtime.spec.ts:
capture and restore process.env.PM_GLOBAL_PATH, and also preserve/reset
PM_TELEMETRY_INLINE_FLUSH and PM_TELEMETRY_FLUSH_CHILD alongside the existing
VITEST, VITEST_WORKER_ID, and NODE_ENV handling. Use the same pattern already in
the test’s finally block so the invalid temp global root does not leak into
later tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3f021d1a-df50-47cf-8ba1-c3fb93a71bca
📒 Files selected for processing (12)
.agents/pm/history/pm-2kkl.jsonl.agents/pm/history/pm-xaib.jsonl.agents/pm/issues/pm-2kkl.toon.agents/pm/issues/pm-xaib.toon.github/workflows/ci.ymlsrc/cli/commands/extension/install-sources.tssrc/core/telemetry/runtime.tstests/integration/ci-workflow-contract.spec.tstests/integration/cli.integration.spec.tstests/unit/core/telemetry/telemetry-runtime.spec.tstests/unit/extensions/extension-command.spec.tstests/unit/packages/runtime-loaders.spec.ts
…mini, GH-363) Addresses the Gemini HIGH review finding: fileURLToPath throws ERR_INVALID_FILE_URL_PATH on Windows for a driveless absolute path (e.g. a POSIX-style `file:/Users/...` supplied on Windows, or the regression fixture's `file:///opt/...`), which would crash `pm install` instead of resolving the spec. normalizeNpmLocalFileAliasSpec now decodes an absolute file: URL target with URL + decodeURIComponent (platform-independent, never throws) and strips the leading slash before a Windows drive letter, so npm pack always receives a decoded native path. Relative targets still resolve against cwd. The resolver contract tests assert platform-independent decoded literals and add a drive-letter case covering the leading-slash strip. Full suite green (5096 tests, 100/100/100/100 coverage); typecheck, static and docs/skills gates pass; space-path install re-verified end-to-end on Linux. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PY9Gnrmrh9EVxGmpBVAv9j
|
Pushed 31ca73f addressing review feedback: @gemini-code-assist (HIGH, install-sources.ts): Confirmed real — @coderabbitai (telemetry-runtime.spec.ts env restore): This is already handled — the suite-level Re-review the full diff please: |
|
To use Codex here, create a Codex account and connect to github. |
|
I’m withdrawing my earlier The Windows path note is also helpful — especially the I’ll re-review the full diff with that updated context. ✏️ Learnings added
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Code Review
This pull request addresses several Windows-specific and cross-platform issues. It resolves a teardown crash (GH-348) by adding an 'error' event listener to the detached telemetry flush spawn and mocking node:child_process in its unit tests to prevent orphan processes. It also fixes an npm installation regression (GH-363) by ensuring resolveNpmPackSpec and normalizeNpmLocalFileAliasSpec return native decoded filesystem paths instead of percent-encoded file URLs, preventing ENOENT errors on paths containing spaces or Windows 8.3 short names. Finally, it fixes a test fixture in runtime-loaders.spec.ts where a reserved colon character caused mkdir to fail on Windows. No review comments were provided, and I have no further feedback.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…eRabbit) Addresses the CodeRabbit review note: the non-inline flush-scheduler tests mutate PM_GLOBAL_PATH, PM_TELEMETRY_INLINE_FLUSH and PM_TELEMETRY_FLUSH_CHILD in addition to VITEST/VITEST_WORKER_ID/NODE_ENV. The suite afterEach already resets these, but the per-test finally now snapshots and restores every mutated key via a small snapshotEnv helper so each scheduler test is fully self-contained and cannot leak into a sibling test regardless of teardown order. Full suite green (5096 tests, 100/100/100/100 coverage); typecheck, static and docs/skills gates pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PY9Gnrmrh9EVxGmpBVAv9j
|
Pushed a39e0a8 applying the CodeRabbit env-restore note: the non-inline flush-scheduler tests now snapshot and restore every mutated env var ( @coderabbitai full review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Code Review
This pull request addresses several cross-platform and Windows-specific issues. It ensures that local npm package paths and file aliases are resolved to native filesystem paths rather than percent-encoded file URLs, preventing npm pack from failing with ENOENT on paths with spaces or Windows 8.3 short names. It also hardens the detached telemetry flush spawn by adding an error listener to swallow asynchronous spawn failures, avoiding vitest worker crashes on teardown. Additionally, it fixes a Windows test failure caused by a reserved colon character in a directory fixture and mocks child processes in telemetry tests to prevent orphan processes. Feedback is provided to wrap the URL parsing and percent-decoding logic in a try-catch block to prevent potential synchronous exceptions from crashing the CLI.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| const decodedPath = decodeURIComponent(new URL(`file:${target}`).pathname); | ||
| const nativePath = /^\/[A-Za-z]:/.test(decodedPath) ? decodedPath.slice(1) : decodedPath; | ||
| return `${packageName}@${nativePath}`; |
There was a problem hiding this comment.
The URL parsing and percent-decoding logic using new URL and decodeURIComponent can throw synchronous exceptions (such as TypeError for invalid URLs or URIError for malformed percent-encoded sequences). To prevent these exceptions from crashing the CLI, wrap this block in a try-catch statement and gracefully fall back to returning the original spec if parsing or decoding fails.
try {
const decodedPath = decodeURIComponent(new URL("file:" + target).pathname);
const nativePath = /^\/[A-Za-z]:/.test(decodedPath) ? decodedPath.slice(1) : decodedPath;
return packageName + "@" + nativePath;
} catch {
return spec;
}…g (Gemini) Addresses the Gemini review finding: decodeURIComponent throws a URIError on a malformed percent sequence (e.g. `%ZZ`), so `pm install npm:name@file:///…/%ZZ/…` would crash the CLI with an uncaught exception. normalizeNpmLocalFileAliasSpec now wraps the URL parse + decode in try/catch and returns the spec untouched on failure, letting npm surface a clear error. Added a malformed-percent contract test covering the fallback. Full suite green (5096 tests, 100/100/100/100 coverage); typecheck, static and docs/skills gates pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PY9Gnrmrh9EVxGmpBVAv9j
|
Pushed e459ca5 applying the Gemini robustness note: @coderabbitai full review |
|
✏️ Learnings added
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Code Review
This pull request addresses several Windows-specific nightly CI failures (GH-363 and GH-348). It fixes a teardown worker crash by adding an error listener to the detached telemetry flush spawn and mocking child processes in unit tests. It also resolves an npm install issue by passing native, percent-decoded filesystem paths to npm pack instead of percent-encoded file URLs, which previously failed on paths containing spaces or Windows 8.3 short names. Additionally, a test fixture in runtime-loaders.spec.ts was updated to avoid using a reserved colon character on Windows. Feedback points out a potential bug in normalizeNpmLocalFileAliasSpec where absolute Windows paths like file:///C:/path could be incorrectly treated as UNC paths and bypass decoding, and provides a code suggestion to resolve this.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| return `${packageName}@${pathToFileURL(absolutePath).href}`; | ||
| // `file://host/share` (exactly two leading slashes) is a UNC / network spec, | ||
| // not a local path — leave it for npm to resolve. | ||
| if (target.startsWith("//") && !target.startsWith("///")) { |
There was a problem hiding this comment.
This check for UNC paths appears to have a bug on Windows. A file: URL for an absolute Windows path like file:///C:/path will result in a target of //C:/path. This condition will evaluate to true and incorrectly return the original spec, treating it as a UNC path. This will prevent it from being correctly decoded later in the function.
This would cause the new test case you added for Windows paths with percent-encoding to fail. A more specific check is needed to differentiate a UNC hostname from a Windows drive letter.
| if (target.startsWith("//") && !target.startsWith("///")) { | |
| if (target.startsWith('//') && !target.startsWith('///') && !/^[a-zA-Z]:/.test(target.slice(2))) { |
There was a problem hiding this comment.
Thanks, but this is a false positive — a slash miscount. For an absolute path the file URL is file:///C:/path (three slashes: file: + empty authority // + /C:/path). After stripping the @file: marker, target is ///C:/path (three leading slashes), not //C:/path. So target.startsWith('///') is true, making !target.startsWith('///') false, and the UNC branch is correctly not taken — the drive path falls through to the decode.
Empirically, the added contract test normalizeNpmLocalFileAliasSpec('alias@file:///C:/Temp/pm%7Eshort/pkg') returns 'alias@C:/Temp/pm~short/pkg' and passes in CI (Gates coverage + Windows regression Node 24 both green). The //C:/path two-slash form is a non-standard file://host shape (host=C:) and is intentionally left for npm. Keeping the current check.
… and regenerate CHANGELOG pm-xaib resolved: runtime-loader colon-path, telemetry detached-spawn error handler, and npm-pack native-path fixes verified on the windows-latest/Node 24 regression job. pm-2kkl (teardown worker crash) stays open with the root-cause fix documented, pending confirmation by the next scheduled nightly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PY9Gnrmrh9EVxGmpBVAv9j
Summary
Fixes the Windows nightly (Node 24) failure tracked in GH-363 / GH-348 (
pm-xaib, root cause ofpm-2kkl). The nightly went red on the 2026-06-24 matrix bump from Node 20 → Node 24 with three distinct, deterministic symptoms; this PR fixes all three and hardens the per-PRwindows-regressionNode 24 oracle so the classes are caught before the nightly.Root causes & fixes
Telemetry detached-spawn unhandled error → vitest worker crash (root cause of the long-standing Nightly Validation failed: windows-latest / Node 20 #348 "Worker forks emitted error / Worker exited unexpectedly" teardown crash).
scheduleTelemetryFlushinsrc/core/telemetry/runtime.tslaunched the detached flush worker viaspawn()without achild.on("error", …)listener. An asynchronous spawn failure (locked-down Windows runner / EACCES / missing runner) emits an unhandled'error'event that Node re-throws as an uncaught exception — crashing the foreground CLI and, under tests, the vitest fork worker on teardown. The sibling searchdispatchRefreshChild(src/core/search/background-refresh.ts) already had exactly this guard; telemetry was the lone outlier.child.on("error", …)that swallows the failure and releases the spawn gate (mirrorsbackground-refresh), so a later flush retries.VITESTand launched a real, network-touching, untrackednodeflush child (orphaned on Windows). It now mocksnode:child_processlike the gold-standardbackground-refresh.spec.ts, plus a focused regression test that emits an async'error'and asserts the spawn gate is released.runtime-loaders.spec.tscolon-pathENOENT(pm-beads + pm-todos).The ERR_MODULE_NOT_FOUND path-normalization coverage fixture synthesized a literal
C:\pm\projectdirectory segment; the colon is reserved on Windows somkdirraisedENOENT. The fixture is now platform-aware — on Windowspath.joinalready yields the native-separator divergence; on POSIX a backslash-bearing segment is injected — exercising the loader's backslash-normalizing branch identically on both platforms with no coverage change.cli.integration.spec.ts"installs runtime dependencies for packed npm package extensions" returned install code 1 (Windows-only npm.cmdshell-spawn / tar / hosted-SDK junction class).Added an assertion message that surfaces the install
stderr/stdoutso the platform-specific failure is diagnosable from CI rather than a bareexpected 1 to be 0, and added the case to thewindows-regressionNode 24 job.CI hardening
The per-PR
windows-regression(Node 24) job now also runsruntime-loaders.spec.ts,telemetry-runtime.spec.ts, and the packed-npm-extension install integration case, so all three Windows classes fail this required check pre-merge instead of only the scheduled nightly. Theci-workflow-contractspec is updated to lock the new commands.Verification
windows-regressionNode 24 job.Closes GH-363. Resolves the root cause of GH-348 /
pm-2kkl(closed once the next nightly is green).🤖 Generated with Claude Code