Skip to content

Fix protected-main auto-release token and contracts namespaces #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unbraind merged 1 commit into from
Jun 25, 2026
Merged

Fix protected-main auto-release token and contracts namespaces #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions .agents/pm/history/pm-9gxi.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

19 changes: 19 additions & 0 deletions .agents/pm/history/pm-y1o4.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,20 @@
{"ts":"2026-06-25T04:53:47.719Z","author":"codex-pm-ecosystem-audit-20260625","op":"create","patch":[{"op":"add","path":"/metadata/id","value":"pm-y1o4"},{"op":"add","path":"/metadata/title","value":"Contracts command lookup should handle package namespace roots"},{"op":"add","path":"/metadata/description","value":"The 2026-06-25 source-map audit found that an installed package namespace can expose help at the root command path while pm contracts --command <namespace> reports unknown_command; child command lookup works."},{"op":"add","path":"/metadata/type","value":"Issue"},{"op":"add","path":"/metadata/status","value":"open"},{"op":"add","path":"/metadata/priority","value":2},{"op":"add","path":"/metadata/tags","value":["agent-ux","area:contracts","area:mcp","area:packages"]},{"op":"add","path":"/metadata/created_at","value":"2026-06-25T04:53:47.719Z"},{"op":"add","path":"/metadata/updated_at","value":"2026-06-25T04:53:47.719Z"},{"op":"add","path":"/metadata/author","value":"codex-pm-ecosystem-audit-20260625"},{"op":"add","path":"/metadata/estimated_minutes","value":120},{"op":"add","path":"/metadata/acceptance_criteria","value":"The intended contract behavior for package namespace roots is defined; pm contracts either returns namespace metadata/child-command guidance for roots like changelog or emits a clearer package-namespace error; regression coverage exercises installed package namespace root and child command; pnpm contracts:check and package command discovery tests pass."},{"op":"add","path":"/metadata/parent","value":"pm-5k4v"},{"op":"add","path":"/metadata/repro_steps","value":"Run node dist/cli.js changelog --help, then node dist/cli.js contracts --command changelog --flags-only --json and node dist/cli.js contracts --command \"changelog generate\" --flags-only --json."},{"op":"add","path":"/metadata/expected_result","value":"Contracts lookup gives useful namespace-level metadata or a precise guidance error for the package namespace root, while child command lookup remains valid."},{"op":"add","path":"/metadata/actual_result","value":"Root namespace help exists, but contracts --command changelog returns unknown_command; contracts --command \"changelog generate\" works."},{"op":"add","path":"/metadata/comments","value":[{"created_at":"2026-06-25T04:53:47.719Z","author":"codex-pm-ecosystem-audit-20260625","text":"Duplicate check before create: status-all search for contracts --command changelog unknown_command package root command full path changelog generate found related closed items pm-7etc, pm-4os2/pm-d6kq class work, and pm-zqes class work, but no open direct namespace-root contracts item."}]}],"before_hash":"3cc22dff72be7b14824654a7a64ea62b04799939b2fee54c1b5f52ca60bf6df0","after_hash":"da1266e103d3eaafc6bd1daa7bb4a1c90eb7208b3a779e90e411562839e865cf","message":"Create package namespace contracts tracking issue"}
{"ts":"2026-06-25T11:23:05.340Z","author":"codex-20260625","op":"claim","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:23:05.340Z"},{"op":"add","path":"/metadata/assignee","value":"codex-20260625"}],"before_hash":"da1266e103d3eaafc6bd1daa7bb4a1c90eb7208b3a779e90e411562839e865cf","after_hash":"4fbc3f60bc75472c67253d23e466f7b6fcd012bfc60cccad7f4cf79934c7099c"}
{"ts":"2026-06-25T11:25:35.391Z","author":"codex-20260625","op":"update","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:25:35.391Z"},{"op":"replace","path":"/metadata/status","value":"in_progress"}],"before_hash":"4fbc3f60bc75472c67253d23e466f7b6fcd012bfc60cccad7f4cf79934c7099c","after_hash":"b9e0ed0ea71661360c525c589689059ba10e1ded02da1501e80706ddc9e820fb","message":"Start package namespace contracts remediation."}
{"ts":"2026-06-25T11:25:35.678Z","author":"codex-20260625","op":"files_add","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:25:35.678Z"},{"op":"add","path":"/metadata/files","value":[{"path":"tests/unit/commands/contracts-command.spec.ts","scope":"project","note":"regress namespace root and child command contract behavior"}]}],"before_hash":"b9e0ed0ea71661360c525c589689059ba10e1ded02da1501e80706ddc9e820fb","after_hash":"a36e8cff414b0150f21b7476449fe1aa45a2970ad53caf56a77551ec96746435"}
{"ts":"2026-06-25T11:25:35.702Z","author":"codex-20260625","op":"files_add","patch":[{"op":"replace","path":"/metadata/files/0/note","value":"emit command_namespace guidance for package command roots"},{"op":"replace","path":"/metadata/files/0/path","value":"src/cli/commands/contracts.ts"},{"op":"add","path":"/metadata/files/1","value":{"path":"tests/unit/commands/contracts-command.spec.ts","scope":"project","note":"regress namespace root and child command contract behavior"}},{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:25:35.702Z"}],"before_hash":"a36e8cff414b0150f21b7476449fe1aa45a2970ad53caf56a77551ec96746435","after_hash":"2df9bbe7314bd3b99a6151c1e25d2c10a0b88a9016db969bf3ebfb42d0e09640"}
{"ts":"2026-06-25T11:26:13.670Z","author":"codex-20260625","op":"tests_add","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:26:13.670Z"},{"op":"add","path":"/metadata/tests","value":[{"command":"node scripts/run-tests.mjs test -- tests/unit/commands/contracts-command.spec.ts","scope":"project","timeout_seconds":240}]}],"before_hash":"2df9bbe7314bd3b99a6151c1e25d2c10a0b88a9016db969bf3ebfb42d0e09640","after_hash":"4d924f41946352e42cfda11a9473faf3c8c07b767f28c818873e543b731c2587"}
{"ts":"2026-06-25T11:26:39.265Z","author":"codex-20260625","op":"test_run_track","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:26:39.265Z"},{"op":"add","path":"/metadata/test_runs","value":[{"run_id":"test-local-mqtf2w7w-ehc5qs","kind":"test","status":"passed","started_at":"2026-06-25T11:26:32.946Z","finished_at":"2026-06-25T11:26:39.260Z","recorded_at":"2026-06-25T11:26:39.260Z","passed":1,"failed":0,"skipped":0}]}],"before_hash":"4d924f41946352e42cfda11a9473faf3c8c07b767f28c818873e543b731c2587","after_hash":"cd5f64e4992f671e5aaa9ba509d37969553538947da285ae7cb1bd045b96ed96","message":"Track test run summary (test-local-mqtf2w7w-ehc5qs)"}
{"ts":"2026-06-25T11:52:09.763Z","author":"codex-20260625","op":"tests_add","patch":[{"op":"add","path":"/metadata/tests/1","value":{"command":"pnpm contracts:check","scope":"project","timeout_seconds":240}},{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:52:09.763Z"}],"before_hash":"cd5f64e4992f671e5aaa9ba509d37969553538947da285ae7cb1bd045b96ed96","after_hash":"3dc85764b1d98ab7177666b292f3c0ada364c2451b16dbe2911b2e31c12275da"}
{"ts":"2026-06-25T11:52:14.770Z","author":"codex-20260625","op":"comment_add","patch":[{"op":"add","path":"/metadata/comments/1","value":{"created_at":"2026-06-25T11:52:14.770Z","author":"codex-20260625","text":"Evidence: implemented command_namespace guidance for package namespace roots in contracts lookup; added regression coverage for changelog namespace roots and child commands. Verification passed: node scripts/run-tests.mjs test -- tests/unit/commands/contracts-command.spec.ts (36 tests), pnpm contracts:check, node scripts/run-tests.mjs coverage (100/100/100/100), static-quality gate docstrings 237/237 source and 1840/1840 exported."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:52:14.770Z"}],"before_hash":"3dc85764b1d98ab7177666b292f3c0ada364c2451b16dbe2911b2e31c12275da","after_hash":"876076a7415e2f76d6b9f9856ec8d0c970652d0ebc3ac34182306ba0f0e1e7d0"}
{"ts":"2026-06-25T11:52:21.279Z","author":"codex-20260625","op":"update","patch":[{"op":"replace","path":"/metadata/actual_result","value":"pm contracts --command changelog now reports command_namespace with concrete changelog export/generate retry examples; changelog generate/export child lookups return extension-provided flag contracts."},{"op":"replace","path":"/metadata/expected_result","value":"pm contracts --command <package namespace> gives precise child-command guidance instead of unknown_command, while pm contracts --command '<namespace> <child>' continues to return the child command flags."},{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:52:21.279Z"},{"op":"add","path":"/metadata/resolution","value":"Implemented command_namespace recovery for package namespace roots in pm contracts and preserved child command contracts for installed package commands."}],"before_hash":"876076a7415e2f76d6b9f9856ec8d0c970652d0ebc3ac34182306ba0f0e1e7d0","after_hash":"7b58304dbe53bc5f47281f914e84f29426b0ca705f1ed599c81519d04f80bd01","message":"Record contracts namespace resolution metadata"}
{"ts":"2026-06-25T11:52:27.222Z","author":"codex-20260625","op":"close","patch":[{"op":"remove","path":"/metadata/assignee"},{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:52:27.222Z"},{"op":"replace","path":"/metadata/status","value":"closed"},{"op":"add","path":"/metadata/close_reason","value":"Resolved: contracts now emits command_namespace guidance for package namespace roots and child command contracts remain valid; focused tests, contracts check, full coverage, static quality, and release gates passed."}],"before_hash":"7b58304dbe53bc5f47281f914e84f29426b0ca705f1ed599c81519d04f80bd01","after_hash":"2a3152c28e0b711de9d7b62d446f8d6785b397ae272a7c0c13d3279288d4bc7d"}
{"ts":"2026-06-25T11:52:31.581Z","author":"codex-20260625","op":"release","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:52:31.581Z"}],"before_hash":"2a3152c28e0b711de9d7b62d446f8d6785b397ae272a7c0c13d3279288d4bc7d","after_hash":"a28ff73f3039f0d19ef85eaf068952310aef298fedadd1281cccc1ccf8b5dd1a"}
{"ts":"2026-06-25T11:53:31.416Z","author":"codex-20260625","op":"docs_add","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:53:31.416Z"},{"op":"add","path":"/metadata/docs","value":[{"path":"CHANGELOG.md","scope":"project","note":"generated by pm-changelog after closing namespace contracts item"}]}],"before_hash":"a28ff73f3039f0d19ef85eaf068952310aef298fedadd1281cccc1ccf8b5dd1a","after_hash":"f3130679d6b52446391b89ff6ff00b7e91816cae8942ddf7a3055f778e8009cf"}
{"ts":"2026-06-25T11:53:43.587Z","author":"codex-20260625","op":"comment_add","patch":[{"op":"add","path":"/metadata/comments/2","value":{"created_at":"2026-06-25T11:53:43.587Z","author":"codex-20260625","text":"Evidence: refreshed CHANGELOG.md through pm-changelog 2026.6.20 after closure; pnpm changelog:pm:check now passes with item_count=1340 and changed=false."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T11:53:43.587Z"}],"before_hash":"f3130679d6b52446391b89ff6ff00b7e91816cae8942ddf7a3055f778e8009cf","after_hash":"59b2a99248dff840604548935cc6a0adc09d638e45dcf4a2c0538e8d8732973a"}
{"ts":"2026-06-25T12:05:19.486Z","author":"codex-20260625","op":"comment_add","patch":[{"op":"add","path":"/metadata/comments/3","value":{"created_at":"2026-06-25T12:05:19.486Z","author":"codex-20260625","text":"Review response: split the package namespace-root regression into its own dedicated test case after Gemini feedback. Verification: node scripts/run-tests.mjs test -- tests/unit/commands/contracts-command.spec.ts passed 37 tests."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T12:05:19.486Z"}],"before_hash":"59b2a99248dff840604548935cc6a0adc09d638e45dcf4a2c0538e8d8732973a","after_hash":"280ada09ff765c54fb10ff790af7f290140b20b12e6dfde2e6b3687f0f4d49eb"}
{"ts":"2026-06-25T13:16:42.478Z","author":"codex-gpt5","op":"update","patch":[{"op":"remove","path":"/metadata/close_reason"},{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T13:16:42.478Z"},{"op":"replace","path":"/metadata/status","value":"in_progress"}],"before_hash":"280ada09ff765c54fb10ff790af7f290140b20b12e6dfde2e6b3687f0f4d49eb","after_hash":"10d720a850c0d7ad16bb6c076db8acb850239d2bf5438052e48be93b112f014c","message":"Reopen for PR #366 review follow-up: cap contracts namespace suggestions and fallback candidates to preserve token-efficient error payloads."}
{"ts":"2026-06-25T13:16:42.767Z","author":"codex-gpt5","op":"claim","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T13:16:42.767Z"},{"op":"add","path":"/metadata/assignee","value":"codex-gpt5"}],"before_hash":"10d720a850c0d7ad16bb6c076db8acb850239d2bf5438052e48be93b112f014c","after_hash":"59aa034ddeff9c28d1e1c7eb6ee7f6e96e07d12db2b6d8da326bbf5319d276de"}
{"ts":"2026-06-25T13:23:05.504Z","author":"codex-gpt5","op":"comment_add","patch":[{"op":"add","path":"/metadata/comments/4","value":{"created_at":"2026-06-25T13:23:05.504Z","author":"codex-gpt5","text":"Review response: capped command namespace recovery output after Gemini feedback. Namespace-root errors now display at most 10 child commands in the message and return at most 20 fallback candidates, while still preserving the first concrete retry and examples. Verification passed: node scripts/run-tests.mjs test -- tests/unit/commands/contracts-command.spec.ts (38 tests), node scripts/run-tests.mjs coverage (100/100/100/100; 5098 tests), node scripts/release/static-quality-gate.mjs --json (source docstrings 237/237 and exported docstrings 1840/1840), pnpm contracts:check, pm health summary ok, git diff --check clean."}},{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T13:23:05.504Z"}],"before_hash":"59aa034ddeff9c28d1e1c7eb6ee7f6e96e07d12db2b6d8da326bbf5319d276de","after_hash":"f773032e49afca23f6fabff77d331a22b9d73aa574ded87b89d31488260964ec"}
{"ts":"2026-06-25T13:23:05.998Z","author":"codex-gpt5","op":"close","patch":[{"op":"remove","path":"/metadata/assignee"},{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T13:23:05.998Z"},{"op":"replace","path":"/metadata/status","value":"closed"},{"op":"add","path":"/metadata/close_reason","value":"Closed after PR #366 review follow-up: contracts namespace guidance is now token-efficient for large extension command groups, with bounded displayed children and fallback candidates plus regression coverage and full gates."}],"before_hash":"f773032e49afca23f6fabff77d331a22b9d73aa574ded87b89d31488260964ec","after_hash":"a0f525084d72eddeaef31a5f68bef163da4e5c5c4e7d41e241ef4c188db561e5"}
{"ts":"2026-06-25T13:23:06.409Z","author":"codex-gpt5","op":"release","patch":[{"op":"replace","path":"/metadata/updated_at","value":"2026-06-25T13:23:06.409Z"}],"before_hash":"a0f525084d72eddeaef31a5f68bef163da4e5c5c4e7d41e241ef4c188db561e5","after_hash":"3e2f5d026d35bd0cf55d1b733dac143c76afcadb0bef0b13a7bfdb9523705bb2"}
Loading
Loading