Repository navigation
[codex] Resolve stale auto-release blockers after scheduled publish - #392
Conversation
Add a scheduled-success cleanup step to the Auto Release workflow so a stale blocked-release GitHub issue is closed only after the scheduled path publishes a tag and the downstream Release workflow completes successfully. Document the release-health behavior, extend the workflow contract test, refresh managed pm-changelog metadata from the latest package check, and record pm-7zs0 evidence for linked tests, coverage, telemetry, changelog, health, validation, and temp-directory smoke results.
📝 WalkthroughWalkthroughAdds a new step in the auto-release workflow that, on successful scheduled runs where a tag was published, finds and closes any open "Auto Release blocked" GitHub issue with a comment. The pipeline step receives an ChangesAuto-release blocked issue cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
To use Codex here, create a Codex account and connect to github. |
|
✅ Action performedFull review finished. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a cleanup mechanism for scheduled Auto Release runs, ensuring that any open "Auto Release blocked" GitHub issues are closed automatically after a successful release. It updates the relevant documentation, PM agent metadata, and the CI workflow contract integration tests. The reviewer identified a potential issue in the GitHub Actions workflow conditional expression where comparing a skipped step's output to an empty string can evaluate to true unexpectedly, and suggested a more robust truthiness check.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "id: auto_release", | ||
| "echo \"published_tag=${NEW_TAG}\" >> \"${GITHUB_OUTPUT}\"", | ||
| "name: Resolve blocked scheduled auto-release issue", | ||
| "if: success() && github.event_name == 'schedule' && steps.auto_release.outputs.published_tag != ''", |
There was a problem hiding this comment.
In GitHub Actions, comparing a step output to an empty string using != '' can lead to unexpected behavior if the step is skipped or does not run. In such cases, steps.auto_release.outputs.published_tag evaluates to null, and since null != '' is true in GitHub Actions expressions, the condition will evaluate to true unexpectedly.
To make this check robust against null or undefined outputs, it is safer and more idiomatic to check the truthiness of the output directly:
steps.auto_release.outputs.published_tag
| "if: success() && github.event_name == 'schedule' && steps.auto_release.outputs.published_tag != ''", | |
| "if: success() && github.event_name == 'schedule' && steps.auto_release.outputs.published_tag", |
There was a problem hiding this comment.
Code Review
This pull request implements an automated lifecycle cleanup for scheduled Auto Release issues. When a scheduled auto-release run successfully publishes a tag and the downstream release workflow succeeds, any open "Auto Release blocked" issue is automatically closed. This behavior is documented in docs/RELEASING.md and verified in the integration tests (tests/integration/ci-workflow-contract.spec.ts). Project management metadata and history files have also been updated. There are no review comments provided, so I have no feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Greptile SummaryThis PR closes stale "Auto Release blocked: scheduled run failed" GitHub issues automatically after a successful scheduled publish completes the downstream Release workflow. It adds output exports (
Confidence Score: 5/5Safe to merge — the cleanup step is fully best-effort and cannot affect the job success/failure signal for either the publishing outcome or the downstream alert path. Both GitHub API calls are wrapped in if-not/exit-0 guards so transient failures leave the job successful. The published_tag truthiness check prevents cleanup from running on dry-run or no-publish executions. The success()/failure() guards on the cleanup and alert steps are mutually exclusive. Contract test coverage matches the new step structure. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "Harden auto-release cleanup output guard" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/auto-release.yml:
- Around line 177-193: The close-body currently uses github.sha, which points to
the scheduled trigger commit instead of the commit actually tagged by
auto_release. Update the auto-release workflow step that builds the blocker
comment to use the tagged release commit SHA exported from the auto_release job
(for example via the new tag’s commit lookup), and wire that value into the
Commit field alongside RELEASE_TAG and RUN_URL, or remove the Commit line if you
cannot provide the correct tagged commit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: b902f038-d8c0-4a93-ab08-bc038ece27da
📒 Files selected for processing (6)
.agents/pm/extensions/.managed-extensions.json.agents/pm/history/pm-7zs0.jsonl.agents/pm/reminders/pm-7zs0.toon.github/workflows/auto-release.ymldocs/RELEASING.mdtests/integration/ci-workflow-contract.spec.ts
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 6 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Export the tagged release commit SHA for the stale-blocker close comment and make the success-path issue cleanup best-effort so a GitHub issue API failure cannot turn a successful scheduled publish into a false blocked-release alert. Extend the workflow contract assertions and record post-review pm-7zs0 validation evidence.
|
Post-review fixes pushed in 56d0bb1. Please review the current head again. @codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Code Review
This pull request implements an automatic resolution mechanism for blocked scheduled auto-releases. When a scheduled run successfully publishes a tag and the downstream release workflow succeeds, any open 'Auto Release blocked' issue is automatically closed. These changes are documented in docs/RELEASING.md and verified in tests/integration/ci-workflow-contract.spec.ts. There are no review comments to evaluate, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Use a direct published_tag truthiness check for the scheduled-success cleanup guard so skipped or no-publish runs with absent outputs cannot enter stale issue cleanup. Record the final PR review fix evidence in pm-7zs0 and keep the workflow contract aligned.
|
Final guard fix pushed in 3643418 for the unresolved Gemini thread. Please review the current head again. @codex review |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
To use Codex here, create a Codex account and connect to github. |
|
✅ Action performedFull review finished. |
Summary
Auto Release blocked: scheduled run failedissue after a scheduled Auto Release publishes a tag and the downstream Release workflow succeeds.RELEASE_PATblocker tracked by issue Auto Release blocked: scheduled run failed #374.pm-changelog@2026.6.27metadata from the latest package-owned changelog check.Validation
node scripts/run-tests.mjs test -- tests/integration/ci-workflow-contract.spec.tsPM_AUTHOR=claude-code-agent pm test pm-7zs0 --run --progress(7/7)pnpm buildpnpm typecheckpnpm lintpnpm quality:staticpnpm contracts:checkpnpm security:scanpnpm audit --audit-level moderatepnpm changelog:pm:check(pm-changelog@2026.6.27,CHANGELOG.mdunchanged)pm health --check-only --summary --jsonpm validate --check-resolution --check-history-drift --json(history drift ok; existing resolution metadata backlog remains)node scripts/run-tests.mjs coverage(100/100/100/100)node scripts/release/sentry-telemetry-gate.mjs --json --telemetry-mode best-effort(critical=0 high=0; telemetry finish_error_rate_pct=0.76)PM_PATHandPM_GLOBAL_PATHTracker
pm-7zs0RELEASE_PATconfigured and a scheduled publish succeeds.Summary by cubic
Stops stale "Auto Release blocked" issues from lingering by auto-closing them after a scheduled publish succeeds and the downstream Release workflow completes. Hardens the guard so cleanup runs only when a tag was actually published.
published_sha.published_tagexists so skipped/no-publish runs never enter cleanup.RELEASE_PATblocker in Auto Release blocked: scheduled run failed #374 unchanged.Written for commit 3643418. Summary will update on new commits.