Repository navigation
Refactor update mutation complexity - #413
Conversation
Decompose the high-complexity update command flow and register-mutation action handlers into focused helpers while preserving the existing CLI behavior and command contracts. Remove the obsolete ESLint complexity suppressions for update.ts and register-mutation.ts, add register-command coverage for repeatable schema alias and role routing, and record pm-0n6p evidence for full coverage, lint, contracts, changelog, manual temp-project smoke, GitHub, Sentry, telemetry, and release-state checks.
|
@greptileai |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
📝 WalkthroughWalkthroughRefactors ChangesComplexity decomposition of update and register-mutation
PM task-tracking metadata
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Action performedFull review finished. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI codebase to address CodeFactor complexity warnings. Specifically, it decomposes the highly complex runUpdate method and its nested mutate callback in src/cli/commands/update.ts into smaller, focused helper functions. Similarly, complex action handlers in src/cli/register-mutation.ts (such as those for create, close-many, plan, history-compact, schema, and comments) have been extracted into dedicated helper functions. ESLint complexity suppressions for these files have been pruned, and unit tests in tests/unit/commands/register-commands.spec.ts have been added to cover repeatable schema alias/role routing and programmatic string coercion. There are no review comments to assess, and I have no additional feedback to provide as the changes are clean, well-structured, and fully covered by tests.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI codebase to decompose highly complex methods and action handlers, specifically targeting runUpdate and its nested mutation callback in src/cli/commands/update.ts, as well as several action handlers in src/cli/register-mutation.ts. By extracting these into smaller, focused helper functions, the ESLint complexity suppressions for these files have been successfully removed. Additionally, unit tests were added to verify repeatable schema alias/role routing and programmatic string coercion. There are no review comments to address, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/cli/commands/update.ts`:
- Around line 1614-1616: The canceled-status assignee cleanup in update.ts runs
too early, so applyOwnershipAndIssueMutations can reintroduce an assignee
afterward. Move the canceled-item cleanup to run after
applyOwnershipAndIssueMutations in the update flow, using the existing
statusRegistry.canceled_status check, and when deleting
document.metadata.assignee also add assignee to the tracked mutated fields so
the removal is recorded consistently.
- Around line 1981-1983: The runtime field update loop currently skips values
when a key is present in both context.runtimeFieldUpdates and
context.clearFrontMatterKeys, which hides set/unset conflicts. Update the logic
around the runtime field handling in update.ts so it mirrors the
registered-field validation below: detect the overlap for each fieldKey and
throw an explicit conflict error instead of continuing. Keep the existing
stableValueEquals behavior only for non-conflicting runtime fields.
In `@tests/unit/commands/register-commands.spec.ts`:
- Around line 2106-2115: The test is reaching into Commander internals by
calling schemaCommand._actionHandler directly, which should be avoided. Update
this case to exercise the same add-status review flow through runCliRaw or the
public parse path, and remove the private _actionHandler access while still
asserting the alias and role coercion on schemaCommand.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: d11d9a4b-77d9-41f5-8230-af2692d82073
📒 Files selected for processing (7)
.agents/pm/extensions/.managed-extensions.json.agents/pm/history/pm-0n6p.jsonl.agents/pm/tasks/pm-0n6p.tooneslint-suppressions.jsonsrc/cli/commands/update.tssrc/cli/register-mutation.tstests/unit/commands/register-commands.spec.ts
💤 Files with no reviewable changes (1)
- eslint-suppressions.json
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Resolve PR #413 CodeRabbit feedback by keeping canceled items unassigned after ownership mutations, rejecting runtime schema field set/unset conflicts with runtime-aware option-policy handling, and replacing the register-command private Commander action hook test with a public parse path. Verification: unsuppressed focused ESLint passed; pnpm typecheck passed; focused update/register tests passed; full coverage passed at 100/100/100/100; linked pm-0n6p tests passed coverage, focused suites, contracts, and lint/static quality.
|
Review-fix commit pushed for CodeRabbit findings. Please review current head 57d33b7. @greptileai |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive refactor of the update and register-mutation commands to reduce code complexity and improve maintainability. Key changes include decomposing large functions into smaller, focused helpers, improving validation logic for command options, and removing outdated ESLint complexity suppressions. The refactor also includes updated task metadata and additional unit tests to ensure behavior preservation, particularly regarding assignee handling and runtime field conflicts. I have no feedback to provide as there were no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Merged latest main and pushed post-merge validation evidence. Please review current head dfb8d64.\n\n@greptileai\n/gemini review\n@gemini-code-assist\n@coderabbitai full review |
|
✅ Action performedFull review finished. ✅ Action performedFull review finished. |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
Gemini reported a transient review creation error on current head dfb8d64. Please retry.\n\n/gemini review\n@gemini-code-assist |
There was a problem hiding this comment.
Code Review
This pull request refactors the update command (src/cli/commands/update.ts) and mutation registration handlers (src/cli/register-mutation.ts) by decomposing complex methods into focused, behavior-preserving helper functions to resolve CodeFactor complexity issues. It also removes ESLint complexity suppressions, adds unit tests covering repeatable schema alias/role routing, canceled status assignee overrides, and conflicting runtime field updates, and updates task tracking files. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Final pm closeout commit pushed. Please review current head 547cf16.\n\n@greptileai\n/gemini review\n@gemini-code-assist\n@coderabbitai full review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Code Review
This pull request implements a comprehensive complexity refactoring for the update command and the MCP mutation registration handlers. Specifically, it decomposes the highly complex runUpdate method, its nested mutate callback, and several command action handlers in register-mutation.ts into smaller, focused helper functions, allowing the removal of ESLint complexity suppressions. Additionally, it refines the behavior of the update command by explicitly handling conflicts between --unset and runtime schema fields, ensuring assignee cleanup when an item is canceled, and adding robust unit test coverage for these paths. There are no review comments provided, so I have no feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Changelog fix pushed after pm closeout. Please review current head ff3d774.\n\n@greptileai\n/gemini review\n@gemini-code-assist\n@coderabbitai full review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Code Review
This pull request decomposes the complex runUpdate method, its nested mutation callback in src/cli/commands/update.ts, and the mutation action handlers in src/cli/register-mutation.ts into focused, behavior-preserving helper functions. These refactorings allow the removal of several CodeFactor complexity suppressions from eslint-suppressions.json. Additionally, the changes ensure that an assignee is cleared when an item is canceled, explicitly reject conflicting set/unset options for runtime schema fields, and add corresponding unit test coverage. There are no review comments provided, so I have no feedback to provide on the review itself.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Tag-aware changelog correction pushed. Please review current head eb5f7f2.\n\n@greptileai\n/gemini review\n@gemini-code-assist\n@coderabbitai full review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI commands by decomposing the complex runUpdate method, its nested mutation callback, and several register-mutation action handlers into smaller, focused helper functions to address CodeFactor complexity warnings. It also prunes ESLint complexity suppressions and adds robust test coverage for canceled-status assignee overrides and runtime field set/unset conflicts. The review feedback highlights a potential runtime TypeError in src/cli/commands/update.ts where a non-null assertion operator (!) is used on a .find() result, suggesting a safer fallback instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| const definition = context.runtimeFieldRegistry.definitions.find((candidate) => candidate.metadata_key === fieldKey)!; | ||
| throw new PmCliError( | ||
| `Cannot combine --unset ${fieldKey.replaceAll("_", "-")} with --${definition.cli_flag}`, | ||
| EXIT_CODE.USAGE, | ||
| ); |
There was a problem hiding this comment.
Using a non-null assertion operator (!) on the result of .find() can lead to a runtime TypeError if the field key is not found in the registry. It is safer to handle the potential undefined case gracefully by falling back to a derived flag name.
const definition = context.runtimeFieldRegistry.definitions.find((candidate) => candidate.metadata_key === fieldKey);
const flagName = definition?.cli_flag ?? fieldKey.replaceAll("_", "-");
throw new PmCliError(
`Cannot combine --unset ${fieldKey.replaceAll("_", "-")} with --${flagName}`,
EXIT_CODE.USAGE,
);
|
Gemini runtime-field conflict feedback fixed. Please review current head d477648.\n\n@greptileai\n/gemini review\n@gemini-code-assist\n@coderabbitai full review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI commands by decomposing the complex runUpdate method, its nested mutate callback, and several action handlers in register-mutation.ts into smaller, focused helper functions. This allows the removal of ESLint complexity suppressions for these files. Additionally, the changes address edge cases such as clearing the assignee when an item is canceled, detecting conflicts when unsetting runtime schema fields that are also being updated, and preserving defensive string-to-array coercion for programmatic schema options. Unit tests have been added to cover these new behaviors and ensure 100% coverage is maintained. There are no review comments to address, so no further feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/cli/commands/update.ts`:
- Around line 1991-1993: The conflict error in update.ts is using the metadata
key-derived flag instead of the runtime field definition’s actual CLI flag.
Update the logic around the field conflict check in the update command to read
the registered field definition’s cli_flag and use that value for both sides of
the error message, rather than deriving it from fieldKey. Keep the change
localized to the branch that throws the PmCliError so the reported --unset/--
flag matches the command’s real update flag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3ad73a97-9c19-43cf-9f99-2920d0e6b08f
📒 Files selected for processing (4)
.agents/pm/history/pm-0n6p.jsonl.agents/pm/tasks/pm-0n6p.toonCHANGELOG.mdsrc/cli/commands/update.ts
|
CodeRabbit runtime cli_flag feedback fixed. Please review current head 460f0a0.\n\n@greptileai\n/gemini review\n@gemini-code-assist\n@coderabbitai full review |
|
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Code Review
This pull request decomposes the complex runUpdate function, its nested mutate callback in src/cli/commands/update.ts, and several action handlers in src/cli/register-mutation.ts into smaller, focused helper functions. This refactoring allows the removal of ESLint complexity suppressions for these files. Additionally, the update command now explicitly handles conflicts when combining --unset with runtime schema field values, and ensures that canceling an item correctly clears the assignee and records it in the changed fields. Unit tests have been added to cover these new conflict paths, assignee cleanup behaviors, and programmatic schema alias/role string coercion. There are no review comments to address, so no further feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Greptile check appears stuck on current head 460f0a0 after all CI and other reviews passed. Please retry only Greptile.\n\n@greptileai |
Document the PR #413 merge, post-merge validation, GitHub/security/release checks, Sentry/telemetry evidence, temp-project smoke, and release the pm-92if claim.
Summary
Linked pm item:
pm-0n6punderpm-92if.This PR finishes the CodeFactor complexity remediation for the item-mutation path:
runUpdateand its update mutation callback insrc/cli/commands/update.tsinto focused helpers while preserving update routing, close-status routing, dependency/test/doc/file mutations, runtime fields, and changed-field behavior.src/cli/register-mutation.tsinto named action helpers.eslint-suppressions.json.pm-0n6pthrough the pm CLI.Verification
npm install -g .pm --version->2026.6.30node -v->v26.4.0pnpm -v->10.33.4pnpm buildpnpm typechecknode scripts/run-tests.mjs test -- tests/unit/commands/update-command.spec.ts tests/unit/commands/register-commands.spec.ts-> 175 tests passednode scripts/run-tests.mjs coverage-> 262 files / 5265 tests, 100% statements / branches / functions / linespm test pm-0n6p --run --progress --pm-context tracker --override-linked-pm-context-> coverage, focused tests, contracts, lint all passedpnpm contracts:checkpnpm lint-> ESLint, jscpd, static quality gate passedpnpm changelog:pm:check-> latestpm-changeloggenerated noCHANGELOG.mdchangepnpm exec node scripts/check-secrets.mjs-> no credential-like secrets in tracked filespnpm audit --audit-level moderate-> no known vulnerabilitiespm health --check-only --summary --json-> okpm validate --check-resolution --check-history-drift --check-command-references --strict-exit --json-> ok with pre-existing resolution metadata warnings; command references and history drift cleangit diff --checkManual Smoke
Installed-package smoke in an isolated temp project (
/tmp/tmp.3bglbDFU7O):pm init --defaults --author manual-smokepm schema add-status review --role active --role blocked --alias in_review --alias needs_review --order 20pm schema add-type Spike --description "Manual smoke investigation" --folder spikes --default-status open --alias Investigationpm schema add-field severity_level --type string --commands create,update,list --alias severity --required-types Spikepm get,pm list, andpm healthFinal smoke assertion: custom
Spikeitem reachedreview,severity_level=high, tagscodefactor,sdk, list count 1, health ok.GitHub / Release / Telemetry Sweep
2026-07-01T06:52:39Zfor mainb2617dac.npm view @unbrained/pm-cli versionreturned2026.7.1during the sweep.PM-CLI-16andPM-CLI-1Qwere stale with lastSeen2026-06-13, not evidence of a current regression.pm telemetry status --jsonshowed telemetry enabled with recent successful flush on2026-07-01T08:03:07.606Z.Greptile
Pre-push Greptile review loop:
ee898fbd-4a0d-48f9-9fce-5b22c99f77c5found deadsprintReleasePolicy; fixed.3df1cc5f-6934-4d13-b26e-4a26ea2dea8afound two behavior-preservation concerns; fixed defensive schema string coercion and replace-tests empty cleanup.4cd22b0a-0678-40ee-b5e5-f24b4863ced0returnedCOMMENTS=0, confidence 4, safe to merge.Summary by cubic
Refactors the update command and mutation registration into focused helpers to lower CodeFactor complexity and complete runtime‑aware option‑policy checks. No CLI contract changes; closes
pm-0n6p(underpm-92if) and removes the last ESLint complexity suppressions.Bug Fixes
Refactors
runUpdateand its apply‑callback insrc/cli/commands/update.ts, preserving routing, close‑status handling, dependency/test/doc/file mutations, runtime fields, and changed‑field behavior.src/cli/register-mutation.tsactions into named helpers; switched tests to the public parse path; kept defensive string coercion and ensured repeatable schemarole/aliasflags route as arrays forschema add-statusandadd-type.Written for commit 460f0a0. Summary will update on new commits.
Greptile Summary
This PR completes CodeFactor complexity remediation by decomposing the large
runUpdatefunction and its mutation callback inupdate.ts, and splitting the six large action closures inregister-mutation.tsinto named helpers. All existing routing, field mutation, and validation behavior is preserved, with two deliberate behavior fixes: runtime schema fields are now correctly recognised in--unsettarget parsing for type-policy enforcement, and cancelled items now forcibly clear their assignee even when--assigneeis supplied in the same update.update.ts:runUpdatedecomposes into ~20 focused helpers; introducesUpdateMutationContextandUpdateClearCollectionDefinitioninterfaces; addsruntimeFieldRegistrytoenforceUpdateOptionsByType/collectProvidedUpdatePolicyOptionsto correctly detect runtime field--unsetconflicts; moves cancelled-item assignee removal intomutateUpdateDocument.register-mutation.ts: ExtractsrunCreateAction,runCloseManyAction,runPlanAction,runHistoryCompactAction,runSchemaAction,runCommentsActionplus shared utilities; removes/* c8 ignore next */suppression on the defensive string-coercion path foralias/role, now covered by new tests.--role/--aliasarray routing, programmatic string coercion, cancellation-overrides-assignee behaviour, and--unset+ runtime field conflict; ESLint complexity suppressions for the refactored functions are removed.Confidence Score: 5/5
Safe to merge; behaviour-preserving decomposition with targeted fixes, comprehensive test coverage, and all gates passing.
The refactoring faithfully preserves routing, mutation ordering, and validation logic. The two intentional behaviour changes are each backed by new integration tests and documented in the PR description.
The cancelled-item assignee-removal block in
src/cli/commands/update.ts(mutateUpdateDocument) deserves a second look to confirm the intended scope of the guard.Important Files Changed
runUpdateand its mutate callback. AddsruntimeFieldRegistrytoenforceUpdateOptionsByType/collectProvidedUpdatePolicyOptions(correct fix), extracts context types, and splits mutation logic into focused helpers.collectProvidedUpdatePolicyOptionswith runtime field registry, cancellation-overrides-assignee behaviour, and--unset+ runtime field conflict.--role/--aliasarray routing and defensive string coercion.Prompt To Fix All With AI
Reviews (6): Last reviewed commit: "Use runtime field CLI flag in conflict e..." | Re-trigger Greptile