Repository navigation
Preserve harness authors across all item mutations - #695
Conversation
Route update and close through the shared harness-aware author resolver, cover both mutation paths end to end, acknowledge the pre-fix unknown history events, and record the completed SDK/CLI delivery evidence in pm.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
@greptileai review |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
@coderabbitai full review |
✅ Action performedFull review finished. Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 59 minutes. |
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (32)
📝 WalkthroughWalkthroughThe PR centralizes CLI author resolution through the shared runtime primitive, adds regression coverage for harness attribution, records unknown-author acknowledgment activity, and updates related PM records and changelog entries with closure, resolution, release, and verification metadata. ChangesAuthor provenance and closeout
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant RuntimePrimitives
participant History
CLI->>RuntimePrimitives: resolve author from options, settings, and harness
RuntimePrimitives-->>CLI: return author and author_source
CLI->>History: write update or close event
History-->>CLI: persist attribution metadata
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will degrade performance by 0.1%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | decodeQueryCursor |
114.3 µs | 116.1 µs | -1.55% |
| ❌ | encodeQueryCursor |
101.2 µs | 101.3 µs | -0.14% |
| ❌ | build index (2000 docs x 80 words) |
161.3 ms | 161.3 ms | -0.02% |
| ❌ | tokenizeAlphaNumeric |
367.3 µs | 367.3 µs | 0% |
| ❌ | score query over 2000 docs |
5.6 ms | 5.6 ms | 0% |
| ⚡ | createQueryFingerprint |
517.1 µs | 514.3 µs | +0.55% |
| ⚡ | stableStringify (nested contract) |
161.6 µs | 161.5 µs | +0.06% |
| ⚡ | jaccardSimilarity |
153.4 µs | 153.3 µs | +0.03% |
| ⚡ | normalizeLowercaseWhitespace |
135.9 µs | 135.8 µs | +0.02% |
| ⚡ | build index (200 docs x 40 words) |
8.4 ms | 8.4 ms | +0.02% |
| ⚡ | tokenize + score query over 2000 docs |
7.5 ms | 7.5 ms | +0.01% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix/universal-author-mutation-parity (547e1bc) with main (3a0c570)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/pm/chores/pm-zqpnte.toon:
- Line 57: The canonical close reason in .agents/pm/chores/pm-zqpnte.toon:57
references the wrong PR; change PR `#693` to PR `#695`, then regenerate all derived
history and issue entries at .agents/pm/history/pm-zqpnte.jsonl:18,
.agents/pm/history/pm-1exil1.jsonl:8, .agents/pm/history/pm-1uul.jsonl:11,
.agents/pm/issues/pm-1uul.toon:36, .agents/pm/issues/pm-5q81jq.toon:28,
.agents/pm/issues/pm-954h0o.toon:33, .agents/pm/issues/pm-a24aqt.toon:50,
.agents/pm/issues/pm-a7m7.toon:35, and .agents/pm/issues/pm-f7ik.toon:36 so
every audit entry reflects PR `#695`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a921717a-f57b-4fe1-ac9a-e7a4097da237
📒 Files selected for processing (32)
.agents/pm/chores/pm-zqpnte.toon.agents/pm/extensions/.managed-extensions.json.agents/pm/features/pm-z9x1r2.toon.agents/pm/history/_workspace.jsonl.agents/pm/history/pm-1exil1.jsonl.agents/pm/history/pm-1uul.jsonl.agents/pm/history/pm-5q81jq.jsonl.agents/pm/history/pm-954h0o.jsonl.agents/pm/history/pm-a24aqt.jsonl.agents/pm/history/pm-a7m7.jsonl.agents/pm/history/pm-e3g0h6.jsonl.agents/pm/history/pm-f7ik.jsonl.agents/pm/history/pm-j4ac9a.jsonl.agents/pm/history/pm-oz8u.jsonl.agents/pm/history/pm-s1w0sf.jsonl.agents/pm/history/pm-z9x1r2.jsonl.agents/pm/history/pm-zqpnte.jsonl.agents/pm/issues/pm-1exil1.toon.agents/pm/issues/pm-1uul.toon.agents/pm/issues/pm-5q81jq.toon.agents/pm/issues/pm-954h0o.toon.agents/pm/issues/pm-a24aqt.toon.agents/pm/issues/pm-a7m7.toon.agents/pm/issues/pm-f7ik.toon.agents/pm/issues/pm-j4ac9a.toon.agents/pm/issues/pm-s1w0sf.toon.agents/pm/tasks/pm-e3g0h6.toon.agents/pm/tasks/pm-oz8u.toonCHANGELOG.mdsrc/cli/commands/close.tssrc/cli/commands/update.tstests/unit/sdk/agent-runtime-primitives.spec.ts
|
Gemini Code Assist: acknowledged the sunset notice. No review findings were produced; the remaining configured reviewers and deterministic gates were evaluated. |
|
CodeRabbit action response: acknowledged. The requested full review reached its included limit; the later review surface was still inspected independently. |
|
CodeRabbit rate-limit/walkthrough comment: acknowledged. The walkthrough correctly identifies the shared resolver and regression coverage; the single separate inline assertion about PR lineage was verified and answered in-thread. |
|
CodSpeed report: reviewed. The reported 0.1% delta compares different runtime environments and the changed production paths are author selection, not benchmark hot paths; the benchmark workflow itself passed. Treating this as non-actionable measurement noise. |
|
Codecov report: acknowledged. All modified coverable lines are covered, consistent with the local and CI 100/100/100/100 coverage gates. |
|
Sourcery review: acknowledged the weekly diff-character quota response. It contains no code finding; all independent static, security, coverage, and platform checks are green. |
|
Tracked in PM: pm-z9x1r2. |
Summary
pm updateandpm closethrough the shared harness-aware SDK author resolverpm-changelog2026.7.24pm lineage
Verification
node scripts/run-tests.mjs coverage— 6,291 tests; 100% statements, branches, functions, linespnpm lint— ESLint, duplication, static quality, docstrings, package boundaries, token surfacespnpm audit --audit-level high— no known vulnerabilitiespnpm security:scan— no credential-like secretspm health --check-only --check-telemetry— healthy, zero actionable unknown-author eventsSummary by cubic
Routes
pm updateandpm closethrough the shared harness-aware author resolver to preserve detected authors across all mutations. Also acknowledges pre-fix unknown-author events and regenerates the changelog withpm-changelog.resolveAuthorin both commands; removed local logic to keep SDK/CLI behavior consistent.Written for commit 547e1bc. Summary will update on new commits.