Repository navigation
Conversation
…oesn't poison the next crawl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2380
Problem
When a streamed deep crawl is abandoned early (caller breaks out of async for without closing the generator), deep_crawl_active stays True in the caller's context. The flag was only reset in the generator's finally, which runs on close/GC - too late, and possibly in a different context. The next arun() with a deep-crawl config then saw the flag still set, treated itself as a nested call, and fell through to a single-page crawl.
Fix
Manage the flag around each yield of the stream wrapper instead of relying on generator cleanup:
aclose()s the inner generator so strategy cleanup isn't left to GCTesting