Fix AutoStop doc and test comment wording - #884
Merged
Conversation
Follow-up to #883: - reword a test comment that referenced the reviewer by name - correct the wiki, which said the percentile rank is in milliseconds Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #883, cosmetics only — no behaviour change.
AutoStopTest: reword a test comment that referenced the reviewer by name.site/dat/wiki/AutoStop.md: the Percentile Response Time section said the rank is specified in milliseconds; only the threshold is.Still outstanding from the #883 review, not touched here:
JAutoStopPanelTest.javais missing its trailing newline, and its new assertions use fully-qualifiedorg.junit.Assert.assertEqualsalthough the file already static-imports it.jTextFieldCustomDurationis still constructed and registered for validation but never displayed or read, andAutoStopretains thecustom_validation_durationproperty plusgetCustomValidationDurationAsInt().🤖 Generated with Claude Code