Skip to content

test: sync long-poll echo corpus (invalid waitMs echoes waitedMs:0) - #99

Merged
ristik merged 1 commit into
mainfrom
fix/longpoll-invalid-wait-echo-202611020739
Nov 2, 2026
Merged

ristik merged 1 commit into
mainfrom
fix/longpoll-invalid-wait-echo-202611020739

Conversation

@ristik

@ristik ristik commented Nov 2, 2026

Copy link
Copy Markdown
Member

Fixture and test sync only, no runtime change. Vendors echo.json revision 4 and README from aggregator-go (sha256 a9dad238857c6953b3f65b5c8680cd8dda2786bccb85a6c633b47644b6c4cd86) and updates longpoll.lock (source-commit is the head of the aggregator-go PR, to be re-pinned at merge).

Fixes the stale case-name based two-request expectation in LongPollWireTest: only the bare generic malformed_params without an echo is repeated once. Adds tests feeding the server's invalid-waitMs answers to a valid wait request: an echoed rejection is final, a preflight rejection has no echo. The strict-parser no-echo retry table is unchanged.

Vendor the revised echo.json and README from aggregator-go (revision 4,
echo.json sha256 a9dad238857c6953b3f65b5c8680cd8dda2786bccb85a6c633b47644b6c4cd86)
and update longpoll.lock. No runtime change.

Fix the stale case-name based two-request expectation in LongPollWireTest: only
the bare generic malformed_params without an echo is repeated once. Add tests
that feed the server's invalid-waitMs answers to a valid wait request: an echoed
rejection is final and never retried without the wait, a preflight rejection has
no echo. The strict-parser no-echo retry table is unchanged.

@MastaP MastaP left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving eafb239. This PR syncs fixtures and tests only.

  • The corpus matches aggregator-go #271. All vendored files are byte-identical to it, and longpoll.lock matches them.
  • ./gradlew build passes, with checkstyle and the full test suite. LongPollWireTest runs 85 of 85, including every new invalid-wait case.
  • The batchAnswers expectation fix is required. The old name-based rule expected 2 requests for batch/invalid-wait-malformed-params, which now echoes.
  • The new tests pin the echo check. I dropped !data.has("waitedMs") from LongPoll.isMalformedParams. Eight tests then fail:
    • all 6 echoed invalidWaitAnswersAreFinalBatch cases
    • batchAnswers › batch/unknown-member-with-valid-wait
    • theCapabilityTableDecidesTheRetry

Re-pin. The lock, LongPollCorpusLockTest and the vendored README all point at 09ed2d5c, the first commit of aggregator-go #271. Its second commit, 5c27fce8, changed the upstream README (25b43670… → a7502b6c…), so the vendored README is already out of date. When you re-pin to the merge commit, update all of these together:

  • source-commit
  • readme-sha256 and the README line in the lock
  • the README itself
  • the commit hard-coded in LongPollCorpusLockTest

Merge after #271.

@ristik
ristik merged commit 1496b9a into main Nov 2, 2026
1 check passed
@ristik
ristik deleted the fix/longpoll-invalid-wait-echo-202611020739 branch November 2, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants