Repository navigation
test: sync long-poll echo corpus (invalid waitMs echoes waitedMs:0) - #99
Merged
Merged
Conversation
Vendor the revised echo.json and README from aggregator-go (revision 4, echo.json sha256 a9dad238857c6953b3f65b5c8680cd8dda2786bccb85a6c633b47644b6c4cd86) and update longpoll.lock. No runtime change. Fix the stale case-name based two-request expectation in LongPollWireTest: only the bare generic malformed_params without an echo is repeated once. Add tests that feed the server's invalid-waitMs answers to a valid wait request: an echoed rejection is final and never retried without the wait, a preflight rejection has no echo. The strict-parser no-echo retry table is unchanged.
MastaP
approved these changes
Nov 2, 2026
MastaP
left a comment
Member
There was a problem hiding this comment.
Approving eafb239. This PR syncs fixtures and tests only.
- The corpus matches aggregator-go #271. All vendored files are byte-identical to it, and
longpoll.lockmatches them. ./gradlew buildpasses, with checkstyle and the full test suite.LongPollWireTestruns 85 of 85, including every new invalid-wait case.- The
batchAnswersexpectation fix is required. The old name-based rule expected 2 requests forbatch/invalid-wait-malformed-params, which now echoes. - The new tests pin the echo check. I dropped
!data.has("waitedMs")fromLongPoll.isMalformedParams. Eight tests then fail:- all 6 echoed
invalidWaitAnswersAreFinalBatchcases batchAnswers › batch/unknown-member-with-valid-waittheCapabilityTableDecidesTheRetry
- all 6 echoed
Re-pin. The lock, LongPollCorpusLockTest and the vendored README all point at 09ed2d5c, the first commit of aggregator-go #271. Its second commit, 5c27fce8, changed the upstream README (25b43670… → a7502b6c…), so the vendored README is already out of date. When you re-pin to the merge commit, update all of these together:
source-commitreadme-sha256and the README line in the lock- the README itself
- the commit hard-coded in
LongPollCorpusLockTest
Merge after #271.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixture and test sync only, no runtime change. Vendors echo.json revision 4 and README from aggregator-go (sha256
a9dad238857c6953b3f65b5c8680cd8dda2786bccb85a6c633b47644b6c4cd86) and updates longpoll.lock (source-commit is the head of the aggregator-go PR, to be re-pinned at merge).Fixes the stale case-name based two-request expectation in LongPollWireTest: only the bare generic malformed_params without an echo is repeated once. Adds tests feeding the server's invalid-waitMs answers to a valid wait request: an echoed rejection is final, a preflight rejection has no echo. The strict-parser no-echo retry table is unchanged.