Repository navigation
refactor(shell): Bring the kong builtins in from x - #528
Merged
Merged
Conversation
dragosgheorghioiu
force-pushed
the
dragosg/refactor/kong-builtins
branch
2 times, most recently
from
October 6, 2026 13:41
85edf3a to
d59413e
Compare
dragosgheorghioiu
force-pushed
the
dragosg/refactor/kong-builtins
branch
2 times, most recently
from
October 7, 2026 07:41
6697f4e to
69d559b
Compare
jedevc
approved these changes
Oct 13, 2026
jedevc
left a comment
jedevc
left a comment
Member
There was a problem hiding this comment.
Reviewed-by: Justin Chadwell <justin@unikraft.com>
Approved-by: Justin Chadwell <justin@unikraft.com>
x/shell drops shell/builtins now that the CLI is its only user. kong.go is that package as of x b2c7ab5, renamed; the real grammar's tests cover it. The shared arg types fold into the commands that used them, and :get and :volumes take the CLI's own FormatOpts. Signed-off-by: Dragos Gheorghioiu <dragosg@unikraft.com>
jedevc
force-pushed
the
dragosg/refactor/kong-builtins
branch
from
October 13, 2026 11:13
69d559b to
509130e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x/shelldropsshell/builtinsnow that the CLI is its only user.This is that package as of x b2c7ab5, renamed into
shellbuiltins.