Skip to content

fix: register fee race, Arbitrum crash, dead identity lookup - #479

Open
kingjacob wants to merge 1 commit into
masterfrom
fix/register-protocol-identity
Open

kingjacob wants to merge 1 commit into
masterfrom
fix/register-protocol-identity

Conversation

@kingjacob

Copy link
Copy Markdown
Contributor

Three fixes from a pass over the open issues and the live site.

Register sends no ETH while the fee is loading (fixes #463)

EthRegisterButton defaulted regFee, rebate and the wallet balance to zero until they loaded, or if the reads failed. That made canRegister true, so the button could send register with value: 0, which reverts with NotEnoughFee(0). Wallets report that as "Internal JSON-RPC error", as in the issue. Simulating the reporter's registration on Base with regFee + rebate (0.00063 ETH) succeeds, so the contract side is fine.

The button now stays disabled until all three values are known, and "You do not have enough funds" only shows once they are.

Arbitrum crashes the app (fixes #401)

useToken had no token for Arbitrum, and the data providers call token.toLowerCase(), so the error boundary replaced the whole app with "Oh no, something broke":

  • when picking Arbitrum (v1) or Base Sepolia in the Protocol page's network picker (the issue);
  • on load, for any wallet connected on Arbitrum, which is one of the configured wagmi chains.

Arbitrum now maps to DAI (Union v1), and the Protocol page's picker leaves out testnets, which have no RPC transport, so their data can't load.

Remove the profile's "Verified accounts" section

It fetched identity.union.finance, which no longer serves the identity service (requests fail with a certificate error), so the section has been empty on every profile. This removes the section, its badge component and icons, and its loading skeleton.

Verification

  • New tests: EthRegisterButton.test.jsx (fee and balance loading, value sent, insufficient funds) and useToken.test.js (a token for every Protocol page network, Arbitrum maps to DAI, no testnets). 5 of the 7 fail on master.
  • yarn test (64 passed), yarn lint (0 errors, warning count unchanged), yarn build.
  • Headless browser, with this build served at the app.union.finance URL:
    • wallet connected on Arbitrum: the live site lands on the error page; this build shows the connect page with the "deprecated V1 network" banner;
    • Protocol page: the options are Optimism (v2), Ethereum (GOV), Base (v2) and Arbitrum (v1), and Arbitrum and Ethereum both show their data;
    • profile page: no request to identity.union.finance.

Register (#463): the ETH register button treated a still-loading (or
failed) regFee, rebate and wallet balance as zero, so it could send
`register` with no ETH, which reverts with NotEnoughFee(0). Keep it
disabled until all three are known, and only show "not enough funds"
once they are.

Arbitrum (#401): useToken had no token for Arbitrum, so the data
providers' token.toLowerCase() threw and the error boundary replaced the
whole app. That happened when picking Arbitrum (v1) or Base Sepolia in
the Protocol page's network picker, and on load for any wallet connected
on Arbitrum, a configured wagmi chain. Map Arbitrum to DAI (Union v1)
and leave testnets out of the Protocol page's picker.

Profile: remove the "Verified accounts" section. It fetched
identity.union.finance, which no longer serves the identity service, so
the request always failed and the section was empty on every profile.

Add tests for the register button's loading states and for a token on
every network the Protocol page offers.
@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
union-interface Ready Ready Preview Nov 14, 2026 10:22pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 51be2c43 Deployed Nov 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transaction failure for becoming a member Selection of Base Sepoila at the governance page breaks it

1 participant