Repository navigation
Conversation
Register (#463): the ETH register button treated a still-loading (or failed) regFee, rebate and wallet balance as zero, so it could send `register` with no ETH, which reverts with NotEnoughFee(0). Keep it disabled until all three are known, and only show "not enough funds" once they are. Arbitrum (#401): useToken had no token for Arbitrum, so the data providers' token.toLowerCase() threw and the error boundary replaced the whole app. That happened when picking Arbitrum (v1) or Base Sepolia in the Protocol page's network picker, and on load for any wallet connected on Arbitrum, a configured wagmi chain. Map Arbitrum to DAI (Union v1) and leave testnets out of the Protocol page's picker. Profile: remove the "Verified accounts" section. It fetched identity.union.finance, which no longer serves the identity service, so the request always failed and the section was empty on every profile. Add tests for the register button's loading states and for a token on every network the Protocol page offers.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from a pass over the open issues and the live site.
Register sends no ETH while the fee is loading (fixes #463)
EthRegisterButtondefaultedregFee,rebateand the wallet balance to zero until they loaded, or if the reads failed. That madecanRegistertrue, so the button could sendregisterwithvalue: 0, which reverts withNotEnoughFee(0). Wallets report that as "Internal JSON-RPC error", as in the issue. Simulating the reporter's registration on Base withregFee + rebate(0.00063 ETH) succeeds, so the contract side is fine.The button now stays disabled until all three values are known, and "You do not have enough funds" only shows once they are.
Arbitrum crashes the app (fixes #401)
useTokenhad no token for Arbitrum, and the data providers calltoken.toLowerCase(), so the error boundary replaced the whole app with "Oh no, something broke":Arbitrum now maps to DAI (Union v1), and the Protocol page's picker leaves out testnets, which have no RPC transport, so their data can't load.
Remove the profile's "Verified accounts" section
It fetched
identity.union.finance, which no longer serves the identity service (requests fail with a certificate error), so the section has been empty on every profile. This removes the section, its badge component and icons, and its loading skeleton.Verification
EthRegisterButton.test.jsx(fee and balance loading, value sent, insufficient funds) anduseToken.test.js(a token for every Protocol page network, Arbitrum maps to DAI, no testnets). 5 of the 7 fail onmaster.yarn test(64 passed),yarn lint(0 errors, warning count unchanged),yarn build.identity.union.finance.