Skip to content

pr-set: pin Nemotron 3.5 Super VL and Bolt (ggml-org#30520), repin Inkling #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielhanchen merged 1 commit into from
Oct 15, 2026
Merged

pr-set: pin Nemotron 3.5 Super VL and Bolt (ggml-org#30520), repin Inkling #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scripts/unsloth/feature-checks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,13 @@
{ "kind": "arch", "arch": "diffusion-gemma" }
]
},
"nemotron-3.5": {
"owner": "ggml-org#30520",
"checks": [
{ "kind": "arch", "arch": "nemotron_h_moe" },
{ "kind": "mtmd", "projector": "nemotron_omni" }
Comment on lines +69 to +71

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add coverage for the bundled LiLiCorr path

When an aged nightly base builds this pin, ggml-org#30520 also supplies the unpinned ggml-org#30506 LiLiCorr/DSpark changes in src/models/dflash.cpp, but these checks exercise only the main nemotron_h_moe graph and the projector registry. tests/test-llama-archs.cpp explicitly skips LLM_ARCH_DFLASH, so the new speculative-decoding path is never executed and feature_matrix.py can report ggml-org#30520 demonstrated even if that bundled functionality is broken; add a positive runtime probe for the DFlash/DSpark path rather than treating the pin as fully covered.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exercise the Nemotron Omni projector in this check

When the new Nemotron Omni image/video preprocessing or projector graph regresses, this entry still passes because probe_mtmd() in scripts/unsloth/feature_matrix.py:124-134 never reads check["projector"]; it only runs the same global test_projector_registry filter for every projector and counts its assertions. That verifies registry consistency, not that nemotron_omni can preprocess media or execute its newly added graph, while pin_contract.py only verifies source-line survival; add a projector-specific positive probe so the primary multimodal functionality of ggml-org#30520 cannot remain green without being exercised.

Useful? React with 👍 / 👎.

]
},
"kimi-k3": {
"owner": "unslothai#70",
"checks": [
Expand Down
5 changes: 3 additions & 2 deletions scripts/unsloth/pr-set.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
],
"prs": [
"https://github.com/ggml-org/llama.cpp/pull/24423/commits/6a7388aac74ab896d9d4f0fb187ddac4847c02f0",
"https://github.com/ggml-org/llama.cpp/pull/25731/commits/607b193a546bf7ebd17cca1c3e355c622fcef605",
"https://github.com/ggml-org/llama.cpp/pull/25731/commits/534c32182487ee3277908a91dd02f6d8e8ac7ed4",
"https://github.com/unslothai/llama.cpp/pull/70/commits/883f2c9ba78f3847148454adf025da29385fff3e",
"https://github.com/unslothai/llama.cpp/pull/61/commits/05a66933fc06f6b2eda2288caf506e09f400ed2b",
"https://github.com/unslothai/llama.cpp/pull/95/commits/496a8a646f19b244b5e2eaf4cf64f920ed31c1a3",
Expand All @@ -34,6 +34,7 @@
"https://github.com/unslothai/llama.cpp/pull/251/commits/d466df9211feb3e37d8163ebc6d17bc1be8af189",
"https://github.com/unslothai/llama.cpp/pull/270/commits/7968eda613e427ad5ccbab61df43246a9a82c53a",
"https://github.com/unslothai/llama.cpp/pull/264/commits/5bb68456bc34238cedb50c8683495c6d6f924177",
"https://github.com/unslothai/llama.cpp/pull/266/commits/88035b0f74d0fd076df2012a957950fee0c4615f"
"https://github.com/unslothai/llama.cpp/pull/266/commits/88035b0f74d0fd076df2012a957950fee0c4615f",
"https://github.com/ggml-org/llama.cpp/pull/30520/commits/e64207bab6c2989a4ae5aa8b9e0cbe700e135ee3"

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin a head that does not merge newer upstream history

For every aged base predating October 15, this head follows 3cb3b3f, which merged current upstream master into the PR branch as shown in the PR commit list. The resolver checks out the aged tag and runs git merge --no-ff "$SHA" in .github/workflows/unsloth-prebuilt.yml:326-346; Git merge incorporates the named commit's history since divergence, while --no-ff only forces creation of a merge commit (Git documentation). Consequently this pin imports every unrelated upstream commit through that merged master revision, bypassing UNSLOTH_LLAMA_MIN_RELEASE_AGE_HOURS, rather than adding only ggml-org#30520/ggml-org#30506; use a pin whose ancestry forks before the aged bases or otherwise isolate the reviewed changes.

Useful? React with 👍 / 👎.

]
}