Repository navigation
(graphcache) - Persist results written while the storage is being read - #3926
Open
dargmuesli wants to merge 1 commit into
Open
dargmuesli wants to merge 1 commit into
dargmuesli wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f060352 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
offlineExchange, results written to the cache before the storage'sreadData()has resolved are never persisted.cacheExchangeattaches the storage to the store only once hydration has finished, andupdatePersistonly queues keys whiledata.storageis set. In a server-rendered app every query answered fromssrExchangedata right after the page loads falls into that window, so the data of the page a visit starts on is missing on the next offline start, unless the query happens to run again later.Set of changes
exchanges/graphcache/src/store/data.ts:updatePersistalso queues keys while the store is hydrating, andhydrateDataremoves each key it restores from the storage from that queue again, so stored data isn't written back.exchanges/graphcache/src/store/store.test.ts: a test that writes a record during hydration and checks thatwriteDatareceives it, but not the restored one.@urql/exchange-graphcache.This isn't a breaking change.