Refactor FancyHeader to Use CSS Grid for Dynamic Height - #214
Refactor FancyHeader to Use CSS Grid for Dynamic Height#214betsyecastro wants to merge 2 commits into
Conversation
|
The last commit hides the banner image on screens below lg breakpoint (992px). |
|
@betsyecastro, @wunc, I pulled in the changes and tested the following functionality (used
Unrelated to PR changes, and quite likely due to using |
shukla-m
left a comment
There was a problem hiding this comment.
See comments. I did NOT test the visual rendering of the uploaded image, but the code changes look fine.
|
Hi @shukla-m, as I mentioned yesterday, I'm almost sure that the reason why you couldn't render the images is related to the transition from valet to Docker. These are similar issues I ran into when reviewing PR #222:
Refer to this comment, where I mentioned what worked for me. |
Hi @betsyecastro, thanks for the suggestions! I removed the existing symlinks via |
Replaces the fixed-height
background-imageapproach with an<img>tag and CSS Grid. This allows the header height to adjust dynamically based on either the image or the content, whichever is taller.Changes
background-imagestyle with<img class="banner-img">elementheight: 85vhin favor of dynamic sizingobject-fit: coverandobject-position: centerfor consistent image scalingmax-heightandoverflow-y: autofrom.contact_infoto let content flow naturally.profile-headerpadding and background on.fancy_headerto prevent style conflicts