Skip to content

Move bug same path - #84

Merged
abnegate merged 4 commits into
mainfrom
move-bug-same-path
Oct 18, 2023
Merged

Move bug same path#84
abnegate merged 4 commits into
mainfrom
move-bug-same-path

Conversation

@fogelito

@fogelito fogelito commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

Fix bug when source and target are identical the file gets deleted.
appwrite/appwrite#5814

@abnegate abnegate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's return true instead of throwing an exception. Since the file will definitely be at $target, any code relying on it will still work, and it'll be easier to consume the library

@abnegate
abnegate merged commit 296a979 into main Oct 18, 2023
utopia-php-monorepo Bot pushed a commit that referenced this pull request Jul 23, 2026
storage 4.0: streams-only I/O, one-word upload verbs, copy replaces transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants