Repository navigation
feat(uucore): support fs feature for redox - #14865
Conversation
bee4a77 to
c008411
Compare
c008411 to
7c7a852
Compare
Merging this PR will degrade performance by 27.2%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | three_39_bit_primes |
302.4 ms | 967.6 ms | -68.74% |
| ⚡ | Simulation | true_consecutive_calls |
350.2 ns | 294.7 ns | +18.85% |
| ⚡ | Simulation | thirteen_39_bit_primes |
9 s | 8.7 s | +3.87% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing xtqqczze:redox-create-link-std (06a4f23) with main (154be8e)2
Footnotes
-
117 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(a7f2dc5) during the generation of this report, so 154be8e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
7c7a852 to
2b378a1
Compare
|
GNU testsuite comparison: |
2b378a1 to
423dc40
Compare
This comment was marked as outdated.
This comment was marked as outdated.
423dc40 to
3d74084
Compare
6a51093 to
a42e254
Compare
```sh cargo clippy --quiet --package uucore --features=fs --all-targets --target=x86_64-unknown-redox ```
a42e254 to
06a4f23
Compare
|
Thanks! |
The
fsfeature now compiles successfully on Redox:Closes #14704