Skip to content

feat(uucore): support fs feature for redox - #14865

Merged
cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:redox-create-link-std
Oct 5, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:redox-create-link-std

Conversation

@xtqqczze

Copy link
Copy Markdown
Collaborator

The fs feature now compiles successfully on Redox:

cargo clippy --quiet --package uucore --features=fs --all-targets --target=x86_64-unknown-redox

Closes #14704

@codspeed

codspeed Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 27.2%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 331 untouched benchmarks
⏩ 117 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation three_39_bit_primes 302.4 ms 967.6 ms -68.74%
⚡ Simulation true_consecutive_calls 350.2 ns 294.7 ns +18.85%
⚡ Simulation thirteen_39_bit_primes 9 s 8.7 s +3.87%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:redox-create-link-std (06a4f23) with main (154be8e)2

Open in CodSpeed

Footnotes

  1. 117 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (a7f2dc5) during the generation of this report, so 154be8e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze
xtqqczze force-pushed the redox-create-link-std branch from 7c7a852 to 2b378a1 Compare September 26, 2026 00:37
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)

@xtqqczze
xtqqczze marked this pull request as ready for review September 26, 2026 08:13
@xtqqczze
xtqqczze force-pushed the redox-create-link-std branch from 2b378a1 to 423dc40 Compare September 26, 2026 12:53
@xtqqczze

This comment was marked as outdated.

@xtqqczze
xtqqczze force-pushed the redox-create-link-std branch from 423dc40 to 3d74084 Compare September 26, 2026 21:39
Comment thread src/uucore/src/lib/features/fs.rs Outdated
```sh
cargo clippy --quiet --package uucore --features=fs --all-targets --target=x86_64-unknown-redox
```
@xtqqczze
xtqqczze force-pushed the redox-create-link-std branch from a42e254 to 06a4f23 Compare October 4, 2026 22:53
@cakebaker
cakebaker merged commit e88a115 into uutils:main Oct 5, 2026
179 of 188 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@xtqqczze
xtqqczze deleted the redox-create-link-std branch October 5, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uucore: fs feature fails to compile on redox

3 participants