Update num-modular, num-bigint, rand and glass_pumpkin. by plugwash · Pull Request #139 · uutils/num-prime

plugwash · 2026-10-06T13:49:09Z

This PR builds on https://github.com/plugwash/num-prime/pull/new/deps to further bump num-modular to 0.6.6 and update other dependencies to get a compatible set.

num-modular 0.6.6 has switched to num-bigint 0.5
num-bigint 0.5 supports rand 0.9 and 0.10 but not 0.8, use latest 0.10
glass_pumpkin (used only in benches) updated to 2.0.0-rc1 to support num-bigint 0.5

Closes #120
Closes #141

sylvestre · 2026-10-06T15:59:28Z

sorry but it needs to be rebased

sylvestre · 2026-10-06T15:59:38Z

+num-bigint = { version = "0.5", features = ["rand_0_10"], optional = true }
 num-integer = "0.1.46"
-num-modular = "0.6.1"
+num-modular = { version = "0.6.6", features = ["num-bigint"] }


this makes num-bigint a hard dependency even with --no-default-features, no?
could it stay behind big-int = ["dep:num-bigint", "num-modular/num-bigint"]?

sylvestre · 2026-10-06T15:59:47Z

-version = "0.4.6"
-features = ["rand"]
-optional = true
+rand = "0.10"


rand 0.10 needs a much newer rustc than the rust-version = "1.70" above.

What num-bigint does is define both rand_0_9 and rand_0_10 features. I was thinking we could do something similar if we don't bump the MSRV yet, since we want rand v0.10 for coreutils.

sylvestre · 2026-10-06T15:59:54Z

 criterion = { package = "codspeed-criterion-compat", version = "5.0.0" }
-glass_pumpkin = "1.2.0"
-num-bigint = { version = "0.4.6", features = ["rand"] }
+glass_pumpkin = "2.0.0-rc1"


do we really want to depend on a release candidate? even if it is just the bench :)

It seems glass_pumpkin bumped to v2 after v1.10.0 was yanked due to the breaking change from upgrading rand_core. I've asked about the roadmap for v2 in LF-Decentralized-Trust-labs/agora-glass_pumpkin#44.

There are very few changes in v2 anyway, so it may be fine to depend on the RC for now.

glass_pumpkin v2.0.0 was released.

plugwash · 2026-10-06T21:50:34Z

I was told to base my PR on #127 so that is what I did.....

sylvestre · 2026-10-07T06:56:23Z

ok, i merged this PR but still conflicts

num-modular 0.6.6 has switched to num-bigint 0.5 num-bigint 0.5 supports rand 0.9 and 0.10 but not 0.8, use latest 0.10 glass_pumpkin (used only in benches) updated to 2.0.0-rc1 to support num-bigint 0.5

plugwash · 2026-10-07T13:07:56Z

@plugwash As per #53, do you agree to dual-license your contribution under MIT OR Apache-2.0?

yes

plugwash · 2026-10-07T13:11:00Z

I've rebased this onto main, dealt with the conflicts and moved the import in nt_funcs into the mod tests.

codecov · 2026-10-07T13:15:02Z

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.07%. Comparing base (3f5db7d) to head (e51b5ee).
⚠️ Report is 87 commits behind head on main.

Files with missing lines	Patch %	Lines
examples/profile_factorization.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   78.64%   86.07%   +7.43%     
==========================================
  Files          13       17       +4     
  Lines        2585     3972    +1387     
  Branches      230      264      +34     
==========================================
+ Hits         2033     3419    +1386     
+ Misses        552      550       -2     
- Partials        0        3       +3

Flag	Coverage Δ
macos_latest	`85.97% <90.00%> (+8.33%)`	⬆️
ubuntu_latest	`85.67% <90.00%> (+7.49%)`	⬆️
windows_latest	`15.25% <0.00%> (+0.55%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codspeed · 2026-10-07T13:17:52Z

Merging this PR will regress 4 benchmarks

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 4 regressed benchmarks
✅ 13 untouched benchmarks
⏩ 9 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`glass_pumpkin`	2.1 ms	8.5 ms	-75.93%
❌	`glass_pumpkin`	321.3 ms	470.1 ms	-31.64%
❌	`glass_pumpkin`	12.5 µs	17.1 µs	-26.77%
❌	`glass_pumpkin (BPSW)`	12.5 µs	16.2 µs	-22.77%
⚡	`glass_pumpkin (BPSW)`	38.9 µs	12.6 µs	×3.1
⚡	`glass_pumpkin`	38.9 µs	13 µs	×3
⚡	`glass_pumpkin`	20.9 ms	8.7 ms	×2.4
⚡	`glass_pumpkin (BPSW)`	27.5 µs	15.9 µs	+72.67%
⚡	`glass_pumpkin`	27.5 µs	16.5 µs	+66.91%
⚡	`glass_pumpkin (BPSW)`	54.5 µs	39.9 µs	+36.47%
⚡	`glass_pumpkin`	54.5 µs	40.4 µs	+34.91%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing plugwash:deps (e51b5ee) with main (0f3dca7)}

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

xtqqczze · 2026-10-07T14:08:53Z

the package num-prime-bench depends on rand, with features: getrandom but rand does not have these features.

plugwash · 2026-10-07T14:24:55Z

I'm at a loss, the tests passed locally and I don't see any mention of getrandom in bench/Cargo.toml.

xtqqczze · 2026-10-07T15:03:37Z

Right, the error seems to be because these changes use rand 0.10, when the MSRV (1.70) does not support that. Ideally, we'd want to define both rand_0_9 and rand_0_10 features, but perhaps you could use rand 0.9 for now?

sylvestre · 2026-10-09T19:40:21Z

clippy and rustfmt are sad :), and a bunch of jobs are failing

sylvestre · 2026-10-09T19:42:47Z

    use super::*;
    use rand::{prelude::SliceRandom, random};
    use std::iter::FromIterator;
+    use rand::prelude::IndexedRandom;


is SliceRandom still used? choose comes from IndexedRandom now.
please merge it into the use rand::{...} above

sylvestre · 2026-10-09T19:43:12Z

 macro_rules! impl_randprime_prim {
    ($($T:ty)*) => {$(
-        impl<R: Rng> RandPrime<$T> for R {
+        impl<R: RngExt> RandPrime<$T> for R {


this changes the public API (rand 0.10 rngs only, num-bigint 0.5 BigUint), so it is a breaking change.
we will need to bump the version to 0.7

We already made a breaking change in #127, so yes will need to bump to 0.7.

sylvestre · 2026-10-12T07:35:41Z

clippy is sad on 2 jobs :)

rustfmt is sad too :)
could you please run cargo fmt?

Diff in /home/runner/work/num-prime/num-prime/bench/benches/bench.rs:4:

 use criterion::{Criterion, SamplingMode};
 use glass_pumpkin::{prime as gprime, safe_prime as safe_gprime};
-use num_bigint::BigUint;
 use num_bigint::BigRng010;
+use num_bigint::BigUint;
 use num_prime::{nt_funcs, RandPrime};
 use rand::rngs::StdRng;
 use rand::SeedableRng;

xtqqczze · 2026-10-23T09:28:02Z

@plugwash Are you planning to continue with this? If not, I’d be happy to take it over.

plugwash · 2026-10-23T14:41:10Z

Feel free to take it over.

xtqqczze · 2026-10-25T15:52:44Z

I've started working on this, but I would like to get #143 merged first.

sylvestre reviewed Oct 6, 2026

View reviewed changes

Comment thread Cargo.toml Resolved

sylvestre reviewed Oct 6, 2026

View reviewed changes

Comment thread src/nt_funcs.rs Resolved

This comment was marked as resolved.

Sign in to view

xtqqczze mentioned this pull request Oct 7, 2026

Upgrade to num-bigint 0.5 #120

Open

Update num-modular, num-bigint, rand and glass_pumpkin.

e51b5ee

num-modular 0.6.6 has switched to num-bigint 0.5 num-bigint 0.5 supports rand 0.9 and 0.10 but not 0.8, use latest 0.10 glass_pumpkin (used only in benches) updated to 2.0.0-rc1 to support num-bigint 0.5

plugwash force-pushed the deps branch from 9433d88 to e51b5ee Compare October 7, 2026 13:05

sylvestre reviewed Oct 9, 2026

View reviewed changes

cmpute mentioned this pull request Oct 13, 2026

chore(deps): update rust crate num-modular to v0.6.6 - autoclosed #141

Closed

1 task

xtqqczze mentioned this pull request Oct 13, 2026

v2.0.0 roadmap LF-Decentralized-Trust-labs/agora-glass_pumpkin#44

Closed

This was referenced Oct 20, 2026

chore(deps): update rust crate glass_pumpkin to v2 #145

Open

fix(deps): update rust crate num-modular to 0.7.0 #144

Open

Conversation

plugwash commented Oct 6, 2026 • edited by cakebaker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sylvestre commented Oct 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

plugwash commented Oct 6, 2026

Uh oh!

sylvestre commented Oct 7, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

plugwash commented Oct 7, 2026

Uh oh!

plugwash commented Oct 7, 2026

Uh oh!

codecov Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed Bot commented Oct 7, 2026

Merging this PR will regress 4 benchmarks

Performance Changes

Footnotes

Uh oh!

xtqqczze commented Oct 7, 2026

Uh oh!

plugwash commented Oct 7, 2026

Uh oh!

xtqqczze commented Oct 7, 2026

Uh oh!

sylvestre commented Oct 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xtqqczze Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sylvestre commented Oct 12, 2026

Uh oh!

xtqqczze commented Oct 23, 2026

Uh oh!

plugwash commented Oct 23, 2026

Uh oh!

xtqqczze commented Oct 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

plugwash commented Oct 6, 2026 •

edited by cakebaker

Loading

codecov Bot commented Oct 7, 2026 •

edited

Loading

xtqqczze Oct 9, 2026 •

edited

Loading