docs: document TreeGrid.getDataProvider without list/lazy views - #10280
Merged
Merged
Conversation
8 tasks
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the changes — left 1 comment.
| Finding | |
|---|---|
| 📝 | Documents a null return that cannot happen, weakening the public contract |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sissbruecker
force-pushed
the
docs/treegrid-getdataprovider
branch
from
September 29, 2026 10:47
86b1200 to
3854d28
Compare
|
vursen
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow#19376
Extracted from to #10029
Contributed by @AzazelSensei
TreeGrid.getDataProvider()that describes the hierarchical data providerTreeGridinherited the javadoc fromGrid.getDataProvider(). That javadoc points togetListDataView()andgetLazyDataView(), which throwUnsupportedOperationExceptiononTreeGridnullwhen the current data provider is not hierarchicalType of change
🤖 Generated with Claude Code