Repository navigation
Conversation
- Add comprehensive write commands classification engine in valkey-common (isWriteCommand, findReadOnlyBlockedCommand) covering standard Valkey mutation commands across strings, hashes, sets, zsets, lists, streams, bitmaps, hyperloglog, geospatial, JSON, cluster, and server configuration - Enforce read-only write prevention on the server in sendRequested action before execution - Provide read-only safety mode toggle with persisted state in Send Command UI - Block write command dispatch on frontend with descriptive error notification - Display active Read-Only Mode badge and status indicator - Add extensive test coverage in common, server, and frontend command slice Fixes valkey-io#402 Signed-off-by: Raj Gahoi <gahoiraj01@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…uite Signed-off-by: Raj Gahoi <gahoiraj01@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #402
Description
This PR introduces a Read-Only Mode for the Send Command tool, preventing accidental or unintended mutation of Valkey servers and production clusters.
Key Changes