Repository navigation
Conversation
- Implement Valkey / Redis cluster slot calculation engine (getKeySlot, getHashTag, crc16) in valkey-common following CRC16-CCITT and hash-tag RFC specification - Enrich BigKey entries on both server and frontend with accurate slotId - Add BigKeysSlotHeatmap and BigKeysSlotHeatmapModal with slot tiles, responsive grid, dynamic heat coloring, legend filter bands, and node filter dropdown - Support slot key inspection listing key name, size, type, and TTL with click-to-navigate action - Add Heatmap button to Big Keys toolbar in cluster mode while hiding in standalone mode - Document Cluster Slot Heatmap feature in activity documentation - Add comprehensive test suites for cluster slot calculation and heatmap components Fixes valkey-io#540 Signed-off-by: Raj Gahoi <gahoiraj01@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #540
Description
This PR introduces a Slot Heatmap for the Big Keys view in cluster mode, following the design and architecture established by the Hot Keys slot heatmap (#503). It allows operators to immediately pinpoint hash slots that concentrate big keys and diagnose cluster memory skew.
Key Changes