[Bug] Windows 10 Edit 工具总是失败 #1217

Activity

1. v7deep

   added

   bugSomething isn't workingSomething isn't working

   on Sep 29, 2026
2. v7deep commented on Sep 30, 2026

   

   v7deep

   on Sep 30, 2026

   Last edited by v7deep

   Author

   More actions

   这是使用AI分析出来的结果: (我觉得不太适合直接PR，给维护者一个参考吧）

   

   *** Begin Patch
   *** Update File: crates/host-core/src/tools/mod.rs
   @@
    fn tool_edit(
   @@
    ) -> Result<Value, hashline::ToolError> {
   @@
   -    let tag = args.get("tag").and_then(|v| v.as_str()).ok_or_else(|| {
   -        hashline::ToolError::new(
   -            "EDIT_TAG_REQUIRED",
   -            "tag required; pass the 4-hex tag from the latest Read, Grep, Write, or Edit",
   -        )
   -    })?;
   -    let ops = args
   -        .get("ops")
   -        .and_then(|v| v.as_str())
   -        .ok_or_else(|| hashline::ToolError::new("INVALID_ARGUMENT", "ops required"))?;
   +    // Claude and a few OpenAI-compatible clients still emit the legacy
   +    // old_string/new_string shape despite receiving the line-anchored schema.
   +    // Adapt that shape at the boundary so a stale client cannot turn every
   +    // Edit into an opaque INVALID_ARGUMENT. The live file is still passed
   +    // through apply_edit below, so the normal hashline write/review path is
   +    // preserved.
   +    let legacy_old = args.get("old_string").and_then(Value::as_str);
   +    let legacy_new = args.get("new_string").and_then(Value::as_str);
   +    let live_for_legacy = if legacy_old.is_some() || legacy_new.is_some() {
   +        Some(std::fs::read(&resolved).map_err(|e| {
   +            if e.kind() == std::io::ErrorKind::NotFound {
   +                hashline::ToolError::new("FILE_NOT_FOUND", format!("File not found: {path}"))
   +            } else {
   +                hashline::ToolError::new("TOOL_FAILED", format!("read failed: {e}"))
   +            }
   +        })?)
   +    } else {
   +        None
   +    };
   +    let (tag, ops) = match (
   +        args.get("tag").and_then(Value::as_str),
   +        args.get("ops").and_then(Value::as_str),
   +        legacy_old,
   +        legacy_new,
   +        live_for_legacy.as_deref(),
   +    ) {
   +        (Some(tag), Some(ops), _, _, _) => (tag.to_string(), ops.to_string()),
   +        (None, None, Some(old), Some(new), Some(bytes)) => {
   +            let file = hashline::normalize_file(bytes);
   +            let tag = hashline::tag_of_lf_text(&file.text);
   +            let matches: Vec<_> = file
   +                .text
   +                .match_indices(old)
   +                .map(|(start, _)| start)
   +                .collect();
   +            if matches.len() != 1 {
   +                return Err(hashline::ToolError::new(
   +                    "EDIT_LEGACY_MATCH_FAILED",
   +                    format!("old_string must match exactly once; found {} matches", matches.len()),
   +                ));
   +            }
   +            let start = matches[0];
   +            let first_line = file.text[..start].bytes().filter(|b| *b == b'\n').count() + 1;
   +            let old_lines = old.lines().count().max(1);
   +            let mut ops = format!("PUT {first_line}.={}:\n", first_line + old_lines - 1);
   +            for line in new.split('\n') {
   +                ops.push('+');
   +                ops.push_str(line);
   +                ops.push('\n');
   +            }
   +            (tag, ops)
   +        }
   +        (None, _, _, _, _) => {
   +            return Err(hashline::ToolError::new(
   +                "EDIT_TAG_REQUIRED",
   +                "tag required; pass the 4-hex tag from the latest Read, Grep, Write, or Edit",
   +            ));
   +        }
   +        (_, None, _, _, _) => {
   +            return Err(hashline::ToolError::new("INVALID_ARGUMENT", "ops required"));
   +        }
   +        _ => {
   +            return Err(hashline::ToolError::new(
   +                "INVALID_ARGUMENT",
   +                "Edit requires either path/tag/ops or path/old_string/new_string",
   +            ));
   +        }
   +    };
   @@
   -        tag,
   -        ops,
   +        &tag,
   +        &ops,
   *** End Patch
   
3. vastsa

   added a commit that references this issue on Oct 1, 2026

   fix(tools): adapt legacy old_string/new_string shape in Edit tool

   ...

   This issue will close once commit ecaf4c6 is merged into the 'main' branch.

   ecaf4c6
4. vastsa

   closed this as completedin #1269on Oct 1, 2026