Skip to content

fix(skills): ignore hidden scoped package entries - #1042

Merged
vastsa merged 1 commit into
mainfrom
fix/skills-skip-hidden-scoped
Sep 25, 2026
Merged

vastsa merged 1 commit into
mainfrom
fix/skills-skip-hidden-scoped

Conversation

@vastsa

@vastsa vastsa commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • Ignore dot-prefixed directories while enumerating scoped npm packages for pi CLI skill discovery.
  • Add regression coverage for Sharp-style hidden staging directories.
  • Preserve discovery of healthy packages and avoid surfacing a false ENOENT diagnostic in Skills.

Fixes #1040

Validation

  • node --test apps/desktop/test/pi-skill-discovery.test.mjs — 10 passed, 1 skipped
  • node scripts/e2e-pi-skill-discovery-ui.mjs — passed
  • pnpm lint:biome — passed
  • pnpm check:pr-base — passed
  • git diff --check — passed

The full desktop typecheck/build remains environment-blocked by missing pre-provisioned audio/voice dependencies and existing localization drift in the primary checkout.

Npm can leave hidden staging directories under scoped packages such as @img. The discovery scan treated them as package candidates and surfaced ENOENT in the Skills page. Skip dot-prefixed scoped children while preserving normal and valid scoped packages.

Add regression coverage for hidden Sharp-style directories so healthy candidates remain discoverable without diagnostics.

fixes #1040
Copilot AI lite review requested due to automatic review settings September 25, 2026 01:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vastsa
vastsa merged commit e0d142b into main Sep 25, 2026
4 checks passed
@vastsa
vastsa deleted the fix/skills-skip-hidden-scoped branch September 25, 2026 01:30
@vastsa vastsa mentioned this pull request Sep 25, 2026

This branch was previously deployed

1 inactive deployment
Preview — 5107b9e6 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]

2 participants