Repository navigation
chore(shell): drop the Mid-Autumn egg and the Chinese dark mascot - #1061
Merged
Merged
Conversation
The festival window had passed, so the seasonal easter egg held no remaining value: it kept a hidden renderer overlay, a settings card, a preference key, a store, dedicated assets and tests alive across nine locale catalogs. Deleting them removes a dormant code path instead of shipping a feature nobody triggers. The Chinese dark home mascot only restated the plain dark artwork for `zh` locales. Removing the dedicated GIF and still makes the mascot selection theme-driven, so Chinese dark mode falls back to the existing dark pair while the light and dark artwork stay untouched. ADR 0152, the EN/CN UX specs and the E2E scenarios now describe the behavior the code implements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mid-Autumn festival window has passed, so the seasonal easter egg is
now dead weight: a hidden renderer overlay, a settings card, a
preference key, a Zustand store, two artwork files, a dedicated test
file and copy in nine locale catalogs. This removes that whole path
rather than shipping a dormant feature.
The Chinese dark home mascot only restated the plain dark artwork for
zhlocales. Dropping the dedicated GIF and still PNG makes the mascotselection theme-driven again: Chinese dark mode falls back to the
existing dark pair, while the light and dark artwork stay untouched.
ADR 0152, the EN/CN UX specs and the E2E scenarios are restored to
describe the behavior the code now implements.
Validation (task worktree, base
origin/main9476456):pnpm --filter @pi-desktop/desktop typechecknode --test test/*.test.mjsinapps/desktop— 2841 pass / 0 failpnpm --filter @pi-desktop/i18n test— 27 passpnpm lint:biome,scripts/check-style-tokens.mjs,pnpm docs:check— cleanelectron-vite build— bundle keeps only the light/dark mascot assetsdark-zh|mid-autumn|easterEgg|彩蛋|30 帧— no hits