Repository navigation
fix(integration): land PRs 1083-1085 with repairs - #1088
Merged
Merged
Conversation
…bootstrap isolation Harden filesystem boundary enforcement, release checksum validation, and bootstrap scripting across Electron Main, BrowserView, and deployment scripts. Previously, browser-view.ts path containment checks did not resolve symlinks, which could allow workspace symlinks targeting files outside the workspace root to be loaded into the preview browser pane. In addition, attachment blob references and release checksum parsing relied on unconstrained segment lookups or loose falsy gates rather than strict hexadecimal SHA-256 schema validation. This change canonicalizes workspace paths with realpathSync, mandates exact 64-character hexadecimal SHA-256 formatting for attachments, restricts local bootstrap directories and tarballs to mode 700/600, eliminates TOCTOU checks in boot verification scripts, and updates git hygiene rules for certificates.
… transform helpers Decompose monolithic entrypoint and central store hotspots to comply with architectural line count and responsibility boundaries (AGENTS.md §7 and §8). In apps/desktop/electron/main/index.ts, more than 350 lines were dedicated to manual getter/setter bridges across 8 mutable state interfaces. In apps/desktop/src/stores/app-store.ts, pure workspace and session data transforms were mixed into the Zustand store definition. This change introduces MainProcessState in bootstrap/main-state.ts to encapsulate main runtime mutable state, extracts workspace git resolution into workspace-git.ts, centralizes error formatting in main-process-errors.ts, and extracts pure session and workspace transformations into stores/helpers/store-helpers.ts. This reduces index.ts from 1,484 to 1,029 lines and app-store.ts from 736 to 617 lines.
Integrate the reviewed security boundary changes into the task candidate.
Integrate the stacked architecture refactor for validation and repair.
Integrate the allocator change for cross-checking and E2E validation.
Close the attachment validation bypass, complete the main-process state migration, and keep source-contract tests aligned with the extracted helpers. Fail bootstrap permission changes closed so the remote host setup cannot silently continue with weaker isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates the reviewed changes from #1083, #1084, and #1085 into the latest main candidate.
Validation
Task candidate commit: fb009d2