Skip to content

fix(chat): follow model thinking defaults on model switch - #1104

Merged
vastsa merged 3 commits into
mainfrom
fix/thinking-effort-model-switch
Sep 26, 2026
Merged

vastsa merged 3 commits into
mainfrom
fix/thinking-effort-model-switch

Conversation

@vastsa

@vastsa vastsa commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • When switching an existing session to a different model, initialize the thinking level from that model binding default. Reselecting the current model preserves a manual level.
  • Add an isolated React/Electron regression for model switch, manual adjustment, and same-model reselection.
  • Update runtime, Composer UX, and E2E scenario documentation.

Validation

  • Composer model-selection E2E passed.
  • Desktop tests: 2946 passed with concurrency 1 (the default-concurrency run hit unrelated npm/SSH timeouts; the 3 affected tests then passed individually).
  • Desktop typecheck, lint, docs checks, and PR-base check passed.

Scope note

The full provider/session desktop journey remains Draft in E2E-089; this PR adds isolated component-hook coverage and does not claim that broader journey ran.

Model-switch defaults are part of the Composer interaction contract. Keep a real React hook regression beside the source guards, while replacing only the app-store boundary in an isolated Electron fixture.

Exercise switching models, changing the level manually, and reselecting the current model. Document that the broader provider/session desktop journey remains Draft.
Copilot AI lite review requested due to automatic review settings September 26, 2026 15:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

The published PR branch cannot be rebased without rewriting shared history. Merge the latest base non-destructively so the PR base gate and integration checks use current main.
@vastsa
vastsa merged commit 14ee953 into main Sep 26, 2026
4 checks passed
@vastsa
vastsa deleted the fix/thinking-effort-model-switch branch September 26, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants